Add provider for https://ok.ru #241
Conversation
|
Thanks for your contribution. I'll take a look and merge it once 1.0 and 2.0 ship (next week). |
|
@PinpointTownes Hey, will it be added in 3.0 or some other release? |
|
It is already available here: https://github.com/Digillect/AspNetCoreOAuthProviders. |
|
|
||
| private static string GetMd5([NotNull] string value) | ||
| { | ||
| var md5 = MD5.Create(); |
There was a problem hiding this comment.
MD5 implements IDisposable, so this needs to be in a using block.
|
|
||
| private string PrepareUserInfoAddress([NotNull] string accessToken, [NotNull] string sig) | ||
| { | ||
| var address = QueryHelpers.AddQueryString(Options.UserInformationEndpoint, "application_key", Options.ApplicationKey); |
There was a problem hiding this comment.
Could use a dictionary like many of the other providers do and do this as a single operation?
|
Thanks for the PR - as part of the preparation for ASP.NET Core 3.0 support, tests are being added to help make things easier to maintain and validate going forwards (see #292). Once tests are merged into the dev branch, could you copy the approach to add tests for the new provider into this PR please? |
|
#280 has been merged to |
|
Closing due to inactivity and merge conflicts - please re-open and rebase if you would like to pursue adding a provider for ok.ru in a future release. |
|
Superseded by #311. |
5 participants
Added provider for Odnoklassniki (https://ok.ru).