Add integration tests #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add integration tests for all of the OAuth providers. Update JetBrains annotations package.
Refactor the handler delegate to use better naming.
Closed
Try and fix DateTimeOffset vs. DateTime differences between 2.2 and 3.0 causing tests to fail in Travis CI.
Fix test by using 2019 instead of 2099 so that Travis CI doesn't decide that the year is 1999 instead.
This was referenced May 13, 2019
Closed
Merged
Closed
Member
Author
|
I'll merge this PR this weekend unless there's any feedback to unblock other PRs to add new providers so they can include tests too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #282 by targeting 2.2 so we can get the benefits of the tests into the dev branch before 3.0 ships in September and #280 is merged.