Skip to content

Add Baidu provider #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Add Baidu provider #245

merged 1 commit into from
May 22, 2019

Conversation

@kinosang
Copy link
Contributor

@kinosang kinosang commented Jun 19, 2018

Re-submitted

@kinosang
Copy link
Contributor Author

kinosang commented Nov 4, 2018

@PinpointTownes Hi, how's it going?

@kinosang
Copy link
Contributor Author

kinosang commented Jan 3, 2019

@PinpointTownes ping

@kevinchalet
Copy link
Member

kevinchalet commented Jan 7, 2019

@kinosang thanks! I'll try to dedicate some time for releasing a patch version and merging pending PRs later this week.

@martincostello martincostello mentioned this pull request May 14, 2019
Closed
martincostello
martincostello reviewed May 14, 2019
View reviewed changes
@martincostello
Copy link
Member

martincostello commented May 14, 2019

Thanks for the PR - as part of the preparation for ASP.NET Core 3.0 support, tests are being added to help make things easier to maintain and validate going forwards (see #292).

Once tests are merged into the dev branch, could you copy the approach to add tests for the new provider into this PR please?

@martincostello
Copy link
Member

martincostello commented May 19, 2019

#280 has been merged to dev now. If you rebase and update any tests as appropriate, we can look at merging this PR soon.

@kinosang
Copy link
Contributor Author

kinosang commented May 22, 2019

@martincostello tests add

martincostello
martincostello reviewed May 22, 2019
View reviewed changes
@kinosang
Copy link
Contributor Author

kinosang commented May 22, 2019

@martincostello done

@martincostello martincostello added this to the 3.0.0 milestone May 22, 2019
@martincostello martincostello merged commit 77b2d1e into aspnet-contrib:dev May 22, 2019
@martincostello
Copy link
Member

martincostello commented May 22, 2019

Thanks for your contribution again @kinosang! 👍

@kinosang kinosang deleted the add-baidu-provider branch May 22, 2019 13:51
@martincostello martincostello modified the milestones: 3.0.0, 2.1.0 May 24, 2019
@martincostello
Copy link
Member

martincostello commented Jun 6, 2019

This provider has now been deployed to NuGet.org - thanks again for your contribution @kinosang! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes

Assignees

No one assigned

Labels

enhancement new provider

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kinosang @kevinchalet @martincostello