-
Notifications
You must be signed in to change notification settings - Fork 42
Adds ability to consume custom extensions #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kevinchalet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this is not the kind of fix I would take: the Attributes collection is meant to be used as a way to request AX attributes (see https://openid.net/specs/openid-attribute-exchange-1_0.html), not to define arbitrary extensions.
To support sending custom parameters (defined in custom extensions), consider implementing #13 instead.
|
Reverted code and implemented the RedirectToProvider notification. Tested it out in our app and was able to accomplish what I needed via that event. |
martincostello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests you can add to validate this scenario?
Co-Authored-By: Martin Costello <[email protected]>
Co-Authored-By: Martin Costello <[email protected]>
|
@kevinchalet Is this capable of being tested via the test project? I've looked through and did not see where the other implemented event has any tests or an example. |
|
@kevinchalet Are you waiting on anything from me to get this pull request through? |
|
@martincostello @kevinchalet Any update on what is holding this up or if you will be moving forward with accepting this change? I'd prefer to use an official package from this project vs a forked version with the change. |
|
Merged, thanks for your PR. A new version should be released soon, but in the meantime, feel free to use the nightly builds. |
Allows the usage of custom extensions via inspecting the authentication property parameter collection.
This is to fix issue #72