Skip to content

Adds ability to consume custom extensions #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2020
Merged

Adds ability to consume custom extensions #73

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b15dcb
Allows the ability to utilzie custom extensions
Feb 18, 2020
55b2085
Removes bad line break
Feb 18, 2020
5a9c28e
Switches string check to use StartsWith instead of Contains
Feb 18, 2020
9a6b1a2
Implements RedirectToProvider notification
Feb 18, 2020
51994e8
Update src/AspNet.Security.OpenId/Events/OpenIdRedirectContext.cs
joskraps Feb 20, 2020
e29d2cd
Update src/AspNet.Security.OpenId/Events/OpenIdRedirectContext.cs
joskraps Feb 20, 2020
ae8c118
Removes erroneous line breaks and properties which are not used.
Feb 20, 2020
b8a40e0
Merge branch 'dev' of https://github.com/joskraps/AspNet.Security.Ope…
Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/AspNet.Security.OpenId/OpenIdAuthenticationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,17 @@ protected override async Task HandleChallengeAsync(AuthenticationProperties prop

foreach (var attribute in Options.Attributes)
{
message.SetParameter(
prefix: OpenIdAuthenticationConstants.Prefixes.Ax,
name: $"{OpenIdAuthenticationConstants.Prefixes.Type}.{attribute.Key}",
value: attribute.Value);
if (attribute.Key.StartsWith("openid.ns"))
{
message.Parameters.Add(attribute.Key, attribute.Value);
}
else
{
message.SetParameter(
prefix: OpenIdAuthenticationConstants.Prefixes.Ax,
name: $"{OpenIdAuthenticationConstants.Prefixes.Type}.{attribute.Key}",
value: attribute.Value);
}
}

// openid.ax.required
Expand All @@ -323,6 +330,15 @@ protected override async Task HandleChallengeAsync(AuthenticationProperties prop
value: string.Join(",", Options.Attributes.Select(attribute => attribute.Key)));
}

foreach (var prop in properties.Parameters)
{
if (prop.Value is string && message.GetParameter(prop.Key) == null)
{
message.SetParameter(prop.Key,
prop.Value.ToString());
}
}

var address = QueryHelpers.AddQueryString(configuration.AuthenticationEndpoint,
message.GetParameters()
.ToDictionary(parameter => parameter.Key,
Expand Down
2 changes: 1 addition & 1 deletion src/AspNet.Security.OpenId/OpenIdAuthenticationMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public string ReturnTo
/// <summary>
/// Gets the parameters associated with this OpenID message.
/// </summary>
protected IDictionary<string, string> Parameters { get; } =
public IDictionary<string, string> Parameters { get; } =
new Dictionary<string, string>(StringComparer.Ordinal);

/// <summary>
Expand Down