-
Notifications
You must be signed in to change notification settings - Fork 87
Enhanced SSM Parameter Resolution and Resource Naming #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced SSM Parameter Resolution and Resource Naming #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a truly excellent Pull Request - I cannot thank you enough!
The fact that PCA did not support multiple stacks in the same region has bugged me, and tripped up many others for so long. This is gold.
Also, I confess - I did not know about the intrinsic function for referencing ssm param values {{resolve:ssm:parameter-name:version}} - so thank you so much for revealing it to me!!
I will pull to a branch and try it out today.. Meantime I left a few (non-critical) review comments - mostly about hidden files that made their way into the PR, and the aesthetics of deleting rather than commenting out lines... all minor stuff.
|
|
||
| DatabaseName: | ||
| Type: String | ||
| Default: 'pca' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than force user to enter a unique database name, can we instead allow an empty default and use a condition in the template to replace an empty DatabaseName with a unique name constructed from the StackName?
|
I'm built it, updated an existing stack, inspected changes, and verified it worked like a charm by processing a couple of jobs. Merging it now to develop branch so a colleague can also merge and test with his feature branch where he's adding Amazon Nova model support. |
|
Looks like I merged too soon - my colleague found issues with fresh deployment.. He will post details here.. |
|
Thanks @dave-moser |
|
Hey @rstrahan . I'll take a look and resubmit the PR with changes. Thank you! |

Changes Made
1. SSM Parameter Resolution
Modified SSM parameter resolution to use proper stack name prefixing using intrinsic functions:
2. Resource ARN Construction
Updated S3 bucket ARN construction:
3. CloudWatch LogGroup Naming
Enhanced LogGroup naming to properly resolve SSM parameters:
4. S3 Path Construction
Improved S3 path construction for better parameter resolution:
5. Lambda SSM retreival
6. Glue Database Name Requirement
Modified database parameter to be required:
Testing Performed
New Stack Deployment
Tested fresh deployment in clean account
Verified all SSM parameters are created correctly
Confirmed resource naming follows expected pattern
Stack Updates
Updated existing stack with new changes
Verified no disruption to running resources
Confirmed backward compatibility
Multiple Stack Deployments
Deployed multiple stacks in same account
Verified parameter isolation between stacks
Confirmed no naming conflicts
Files Changed
pca-main-nokendra.template
pca-main.template
python-utilities.template
ssm.template
trigger.template
boto3.template
bulk.template
ffmeg.template
glue-database.template
pca.template
pca-server.template
pca-ui.template
pcaconfiguration.py
Related Documentation
Checklist
Tested new stack deployment
Tested stack updates