-
Notifications
You must be signed in to change notification settings - Fork 87
Enhanced SSM Parameter Resolution and Resource Naming #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
OlaOla-37 marked this conversation as resolved.
Show resolved
Hide resolved
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -354,8 +354,8 @@ Parameters: | |
|
|
||
| DatabaseName: | ||
| Type: String | ||
| Default: 'pca' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather than force user to enter a unique database name, can we instead allow an empty default and use a condition in the template to replace an empty DatabaseName with a unique name constructed from the StackName? |
||
| Description: Glue catalog database name used to contain tables/views for SQL integration. | ||
| AllowedPattern: "[a-zA-Z0-9_-]+" | ||
| Description: (Required) Glue catalog database name used to contain tables/views for SQL integration. | ||
|
|
||
| EnablePcaDashboards: | ||
| Type: String | ||
|
|
@@ -848,6 +848,7 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-ssm/cfn/ssm.template | ||
| Parameters: | ||
| StackName: !Ref 'AWS::StackName' | ||
| BulkUploadBucketName: | ||
| !If | ||
| - ShouldCreateBulkUploadBucket | ||
|
|
@@ -918,6 +919,8 @@ Resources: | |
| Type: AWS::CloudFormation::Stack | ||
| Properties: | ||
| TemplateURL: pca-server/cfn/lib/python-utilities.template | ||
| Parameters: | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
|
|
||
| BedrockBoto3Layer: | ||
| Type: AWS::CloudFormation::Stack | ||
|
|
@@ -944,6 +947,8 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-server/cfn/pca-server.template | ||
| Parameters: | ||
| DatabaseName: !Ref DatabaseName | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
| ffmpegDownloadUrl: !Ref ffmpegDownloadUrl | ||
| CallSummarization: !Ref CallSummarization | ||
| SummarizationBedrockModelId: !Ref SummarizationBedrockModelId | ||
|
|
@@ -966,6 +971,7 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-ui/cfn/pca-ui.template | ||
| Parameters: | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
| AdminUsername: !Ref AdminUsername | ||
| AdminEmail: !Ref AdminEmail | ||
| AllowedSignUpEmailDomain: !Ref AllowedSignUpEmailDomain | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -395,8 +395,8 @@ Parameters: | |
|
|
||
| DatabaseName: | ||
| Type: String | ||
| Default: 'pca' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rather than force user to enter a unique database name, can we instead allow an empty default and use a condition in the template to replace an empty DatabaseName with a unique name constructed from the StackName? |
||
| Description: Glue catalog database name used to contain tables/views for SQL integration. | ||
| AllowedPattern: "[a-zA-Z0-9_-]+" | ||
| Description: (Required) Glue catalog database name used to contain tables/views for SQL integration. | ||
|
|
||
| EnablePcaDashboards: | ||
| Type: String | ||
|
|
@@ -1031,6 +1031,7 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-ssm/cfn/ssm.template | ||
| Parameters: | ||
| StackName: !Ref 'AWS::StackName' | ||
| BulkUploadBucketName: | ||
| !If | ||
| - ShouldCreateBulkUploadBucket | ||
|
|
@@ -1102,6 +1103,8 @@ Resources: | |
| Type: AWS::CloudFormation::Stack | ||
| Properties: | ||
| TemplateURL: pca-server/cfn/lib/python-utilities.template | ||
| Parameters: | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
|
|
||
| BedrockBoto3Layer: | ||
| Type: AWS::CloudFormation::Stack | ||
|
|
@@ -1128,6 +1131,8 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-server/cfn/pca-server.template | ||
| Parameters: | ||
| DatabaseName: !Ref DatabaseName | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
| ffmpegDownloadUrl: !Ref ffmpegDownloadUrl | ||
| CallSummarization: !Ref CallSummarization | ||
| SummarizationBedrockModelId: !Ref SummarizationBedrockModelId | ||
|
|
@@ -1150,6 +1155,7 @@ Resources: | |
| Properties: | ||
| TemplateURL: pca-ui/cfn/pca-ui.template | ||
| Parameters: | ||
| ParentStackName: !Ref 'AWS::StackName' | ||
| AdminUsername: !Ref AdminUsername | ||
| AdminEmail: !Ref AdminEmail | ||
| AllowedSignUpEmailDomain: !Ref AllowedSignUpEmailDomain | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.