Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 10, 2025

This gives libraries the opportunity to report the feature flags they support, and what values they saw during synthesis.

I purposely did not bump the schema version, since I want this feature to be fully incremental without disturbing existing users: there is no consumption of this new schema yet, that will come later, but we don't want to force people to upgrade their CLI's unnecessarily. That's bad DX.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team June 10, 2025 12:17
@github-actions github-actions bot added the p2 label Jun 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2025 12:18
Signed-off-by: github-actions <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (9545430) to head (0ee6e87).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   79.01%   79.01%           
=======================================
  Files          46       46           
  Lines        7085     7085           
  Branches      790      791    +1     
=======================================
  Hits         5598     5598           
  Misses       1468     1468           
  Partials       19       19           
Flag Coverage Δ
suite.unit 79.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain temporarily deployed to integ-approval June 12, 2025 16:46 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit e272c5e Jun 13, 2025
27 checks passed
@aws-cdk-automation aws-cdk-automation deleted the huijbers/flag-report branch June 13, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants