-
Notifications
You must be signed in to change notification settings - Fork 54
feat(cloud-assembly-schema): add feature flag report as a possible artifact #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a4789d2
be8d0d4
a406e65
b51a75f
d19cfa2
c757d2c
5bd42ad
2152746
0ee6e87
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
…tifact
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -223,11 +223,62 @@ export interface NestedCloudAssemblyProperties { | |
| readonly displayName?: string; | ||
| } | ||
|
|
||
| /** | ||
| * Artifact properties for a feature flag report | ||
| * | ||
| * A feature flag report is small enough that all the properties can be inlined | ||
| * here, and doesn't need an additional file. | ||
| */ | ||
| export interface FeatureFlagReportProperties { | ||
| /** | ||
| * The library that this feature flag report applies to. | ||
| */ | ||
| readonly libraryName: string; | ||
|
|
||
| /** | ||
| * Information about every feature flag supported by this library. | ||
| */ | ||
| readonly flags: Record<string, FeatureFlag>; | ||
| } | ||
|
|
||
| /** | ||
| * A single feature flag | ||
| */ | ||
| export interface FeatureFlag { | ||
| /** | ||
| * The library-recommended value for this flag, if any | ||
| * | ||
| * It is possible that there is no recommended value. | ||
| * | ||
| * @default - No recommended value. | ||
| */ | ||
| readonly recommendedValue?: any; | ||
|
|
||
| /** | ||
| * The value configured by the user | ||
| * | ||
| * This is the value configured at the root of the tree. Users may also have | ||
| * configured values at specific locations in the tree; we don't report on | ||
| * those. | ||
| * | ||
| * @default - Not configured by the user | ||
| */ | ||
| readonly userValue?: any; | ||
|
|
||
| /** | ||
| * Explanation about the purpose of this flag that can be shown to the user. | ||
| * | ||
| * @default - No description | ||
| */ | ||
| readonly explanation?: string; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this not going to be quite a lot of text? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wondering the same thing, but then I came down on, it's probably going to be ~1kB per flag. It's not going to break the bank in terms of file size. |
||
| } | ||
|
|
||
| /** | ||
| * Properties for manifest artifacts | ||
| */ | ||
| export type ArtifactProperties = | ||
| | AwsCloudFormationStackProperties | ||
| | AssetManifestProperties | ||
| | TreeArtifactProperties | ||
| | NestedCloudAssemblyProperties; | ||
| | NestedCloudAssemblyProperties | ||
| | FeatureFlagReportProperties; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "schemaHash": "5dcc6511e8b96c378ad35c391cdc2dcbaa52d08a8015760692eaad73efc9a949", | ||
| "schemaHash": "2d1072dd1745d5fe5fd41ea719ba135791783f186390c14eb8ff23c7e88a945d", | ||
| "revision": 44 | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I like this name. we could use jsii terminology
moduleor something more generic likesource