Skip to content

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Jun 18, 2025

Some users are relying on context values always being a string.

Fixes #629 and #626


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 18, 2025 16:33
@ncino-esselman
Copy link

This would resolve #629 and #626

Copy link

@ncino-esselman ncino-esselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

Copy link

@Kevmo92 Kevmo92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice revert on a breaking change

@otaviomacedo otaviomacedo changed the title revert(cli): retain type of context values and not convert them to string fix: revert "retain type of context values and not convert them to string" Jun 18, 2025
@github-actions github-actions bot added the bug label Jun 18, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (e9c24a6) to head (a7f7d9d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   79.03%   79.01%   -0.02%     
==========================================
  Files          46       46              
  Lines        7092     7086       -6     
  Branches      791      791              
==========================================
- Hits         5605     5599       -6     
  Misses       1468     1468              
  Partials       19       19              
Flag Coverage Δ
suite.unit 79.01% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 76ac13c Jun 18, 2025
59 of 61 checks passed
@aws-cdk-automation aws-cdk-automation deleted the otaviom/revert-context-type branch June 18, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cdk-cli: context variables type changes

8 participants