-
Notifications
You must be signed in to change notification settings - Fork 49
fix: revert "retain type of context values and not convert them to string" #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice revert on a breaking change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 79.03% 79.01% -0.02%
==========================================
Files 46 46
Lines 7092 7086 -6
Branches 791 791
==========================================
- Hits 5605 5599 -6
Misses 1468 1468
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Some users are relying on context values always being a string.
Fixes #629 and #626
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license