Skip to content

fix: revert "retain type of context values and not convert them to string" #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

fix: revert "retain type of context values and not convert them to string" #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/@aws-cdk-testing/cli-integ/resources/cdk-apps/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,8 +453,7 @@ class LambdaStack extends cdk.Stack {
constructor(parent, id, props) {
// sometimes we need to specify the custom bootstrap bucket to use
// see the 'upgrade legacy bootstrap stack' test
const useLegacy = [true, 'true'].includes(parent.node.tryGetContext('legacySynth'));
const synthesizer = useLegacy ?
const synthesizer = parent.node.tryGetContext('legacySynth') === 'true' ?
new LegacyStackSynthesizer({
fileAssetsBucketName: parent.node.tryGetContext('bootstrapBucket'),
})
Expand All @@ -478,8 +477,7 @@ class LambdaStack extends cdk.Stack {

class DriftableStack extends cdk.Stack {
constructor(parent, id, props) {
const useLegacy = [true, 'true'].includes(parent.node.tryGetContext('legacySynth'));
const synthesizer = useLegacy ?
const synthesizer = parent.node.tryGetContext('legacySynth') === 'true' ?
new LegacyStackSynthesizer({
fileAssetsBucketName: parent.node.tryGetContext('bootstrapBucket'),
})
Expand Down
8 changes: 1 addition & 7 deletions packages/aws-cdk/lib/cli/user-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,13 +341,7 @@ function parseStringContextListToObject(argv: Arguments): any {
`User-provided context cannot use keys prefixed with 'aws:', but ${parts[0]} was provided.`,
);
}
let parsedValue: any = parts[1];
try {
parsedValue = JSON.parse(parts[1]);
} catch {
debug('Non-JSON context value for %s, leaving as string: %s', parts[0], parts[1]);
}
context[parts[0]] = parsedValue;
context[parts[0]] = parts[1];
} else {
warning(
'Context argument is not an assignment (key=value): %s',
Expand Down
20 changes: 0 additions & 20 deletions packages/aws-cdk/test/cli/configuration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,23 +116,3 @@ test('providing a build arg', () => {
// THEN
expect(settings.get(['build'])).toEqual('mvn package');
});

test('can parse boolean context from command line arguments', () => {
// GIVEN
const settings1 = commandLineArgumentsToSettings({ context: ['foo=true'], _: [Command.DEPLOY] });
const settings2 = commandLineArgumentsToSettings({ context: ['foo=false'], _: [Command.DEPLOY] });

// THEN
expect(settings1.get(['context']).foo).toEqual( true );
expect(settings2.get(['context']).foo).toEqual( false );
});

test('can parse number context from command line arguments', () => {
// GIVEN
const settings1 = commandLineArgumentsToSettings({ context: ['foo=5'], _: [Command.DEPLOY] });
const settings2 = commandLineArgumentsToSettings({ context: ['foo=3.14'], _: [Command.DEPLOY] });

// THEN
expect(settings1.get(['context']).foo).toEqual( 5 );
expect(settings2.get(['context']).foo).toEqual( 3.14 );
});
Loading