-
Notifications
You must be signed in to change notification settings - Fork 379
Handlers can be async #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2f7eb74
RuntimeClient::next_event returns a Future
illicitonion a5072a0
RuntimeClient::event_response returns a Future
illicitonion 4301ffd
RuntimeClient::event_error returns Future
illicitonion 5adedef
Drive execution from a tokio Runtime
illicitonion 695333c
get_next_event uses a future loop_fn
illicitonion e96a013
Runtime::start is fully async
illicitonion c65d0e5
Handler returns IntoFuture not Result
illicitonion 2f6e599
Add contrived async Handler example
illicitonion 3aa5a85
Update README
illicitonion f2ae75f
cargo fmt
illicitonion 0f253c6
cargo fmt with nightly
illicitonion 5d1de6d
Review comments
illicitonion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update README
- Loading branch information
commit 3aa5a853e47569af0168057d87cbc36bffd90117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these docs! Small phrasing nit—I'd prefer avoiding using “just” in documentation. I'd instead emphasize that due to the
IntoFutureimplementation onResult, most synchronous handlers won't need to make any code changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrased