-
Notifications
You must be signed in to change notification settings - Fork 145
Add newsletter #4 (2018-07-17) #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b69107a to
0b39ff9
Compare
jnewbery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged #19 and rebased this on master.
A few small comments from a quick skim review. I'll fully review this on Monday.
Another great newsletter Dave. I liked the Notable Bitcoin Core merges section.
|
|
||
| - **Transaction fees increasing:** for transactions targeting | ||
| confirmation within 12 blocks or sooner, [recommended fees][] have risen | ||
| up to 3x compared to this time next week. Nodes with default settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time last week?
| information about all active ZMQ notification endpoints. This is | ||
| useful for software that layers on top of bitcoind." | ||
|
|
||
| - **[#13096][]:** Increase the maximum size of transactions that will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a very unlikely edge-case bug. Not sure how interesting this one is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My motivation for including this is that anyone who previously saw that the limit was 99,999 might have coded that into their software (e.g. from that PR, Bitcoin Core used it in its wallet); now that it's higher, they might want to update their software (as that PR updates Bitcoin Core's wallet).
OTOH, if you want to drop it, that's fine by me.
| [#13452]: https://github.com/bitcoin/bitcoin/pull/13452 | ||
| [#13451]: https://github.com/bitcoin/bitcoin/pull/13451 | ||
| [#13580]: https://github.com/bitcoin/bitcoin/pull/13580 | ||
| [#13096]: https://github.com/bitcoin/bitcoin/pull/13072 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad link (although see my comment above about this PR)
No - I generate the website in Jekyll, then copy-paste to mailchimp. Not very automated, but only takes 30 seconds. Go ahead and add the helper functions - I think they'll be very useful. |
|
Looks great. Thanks Dave! |
Newsletters: add #23 (2018-11-27)
Newsletters: add #23 (2018-11-27)
Based on top of #19 . As before, feel free to push/amend/rebase commits on my branch.
One note: a possible dashboard item I ended up removing from this newsletter is that my node has observered a 7x increase in the number of below-default-min-feerate transactions in its mempool over the most I've ever seen before. My guess is that this is just the result of enough more people changing that default setting so that we're forming a better relay network for sub-default txes and they're propagating better. There's really nothing for businesses to do about that, I think, so I decided that it was just a bunch of irrelevant information. However, I could write it back up again if you think it'd be interesting.
One question for @jnewbery: do you use the Markdown at all in generating the emailed newsletter? If not, next week I'd like to maybe add some helper functions for common links which would have the downside of making the file non-portable to other contexts.