Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Jul 14, 2018

Based on top of #19 . As before, feel free to push/amend/rebase commits on my branch.

One note: a possible dashboard item I ended up removing from this newsletter is that my node has observered a 7x increase in the number of below-default-min-feerate transactions in its mempool over the most I've ever seen before. My guess is that this is just the result of enough more people changing that default setting so that we're forming a better relay network for sub-default txes and they're propagating better. There's really nothing for businesses to do about that, I think, so I decided that it was just a bunch of irrelevant information. However, I could write it back up again if you think it'd be interesting.

One question for @jnewbery: do you use the Markdown at all in generating the emailed newsletter? If not, next week I'd like to maybe add some helper functions for common links which would have the downside of making the file non-portable to other contexts.

@jnewbery jnewbery force-pushed the 2018-07-17-newsletter branch from b69107a to 0b39ff9 Compare July 15, 2018 19:24
Copy link
Contributor

@jnewbery jnewbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged #19 and rebased this on master.

A few small comments from a quick skim review. I'll fully review this on Monday.

Another great newsletter Dave. I liked the Notable Bitcoin Core merges section.


- **Transaction fees increasing:** for transactions targeting
confirmation within 12 blocks or sooner, [recommended fees][] have risen
up to 3x compared to this time next week. Nodes with default settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time last week?

information about all active ZMQ notification endpoints. This is
useful for software that layers on top of bitcoind."

- **[#13096][]:** Increase the maximum size of transactions that will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a very unlikely edge-case bug. Not sure how interesting this one is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My motivation for including this is that anyone who previously saw that the limit was 99,999 might have coded that into their software (e.g. from that PR, Bitcoin Core used it in its wallet); now that it's higher, they might want to update their software (as that PR updates Bitcoin Core's wallet).

OTOH, if you want to drop it, that's fine by me.

[#13452]: https://github.com/bitcoin/bitcoin/pull/13452
[#13451]: https://github.com/bitcoin/bitcoin/pull/13451
[#13580]: https://github.com/bitcoin/bitcoin/pull/13580
[#13096]: https://github.com/bitcoin/bitcoin/pull/13072
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad link (although see my comment above about this PR)

@jnewbery
Copy link
Contributor

do you use the Markdown at all in generating the emailed newsletter? If not, next week I'd like to maybe add some helper functions for common links which would have the downside of making the file non-portable to other contexts.

No - I generate the website in Jekyll, then copy-paste to mailchimp. Not very automated, but only takes 30 seconds. Go ahead and add the helper functions - I think they'll be very useful.

@jnewbery jnewbery merged commit 8f454cb into bitcoinops:master Jul 17, 2018
@jnewbery
Copy link
Contributor

Looks great. Thanks Dave!

harding referenced this pull request in harding/bitcoinops.github.io Nov 25, 2018
harding referenced this pull request in harding/bitcoinops.github.io Nov 26, 2018
jnewbery referenced this pull request in harding/bitcoinops.github.io Nov 27, 2018
jnewbery added a commit that referenced this pull request Nov 27, 2018
jnewbery added a commit that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants