Newsletters: add #23 (2018-11-27) #91
Conversation
|
|
||
| - C-Lightning [#2081][c-lightning #2081] and [#2092][c-lightning #2092] | ||
| fix a problem with running multiple RPC commands in parallel. As a | ||
| user-visible change, lightningd now adds a double newline (`\n\n`) |
There was a problem hiding this comment.
Should be lightningd instead fo lightningd to make it consistent with how bitcoind is written below? :-)
| answers made since our last update.* | ||
|
|
||
| - [How could you create a fake signature to pretend to be | ||
| Satoshi?][bse 81115] Gregory Maxwell asks and answers a question about |
There was a problem hiding this comment.
Trailing space on this line :-)
| previously silently ignore the testnet options. This merged PR causes | ||
| it to print a notice: "Warning: Section [testnet] is not recognized." | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: Multiple consecutive blank lines – not needed in Markdown :-)
|
|
||
| Wuille suggests two additions to what metadata is hashed: first, the | ||
| transaction fee is included in the hash in order to ensure hardware | ||
| wallets or offline wallets can be absolutely sure that they aren't |
There was a problem hiding this comment.
Style nit: Would changing from "absolutely sure" to "sure" change the meaning? :-)
|
|
||
| ## Action items | ||
|
|
||
| - **Monitor feerates:** recent reductions in the exchange rate have lead |
There was a problem hiding this comment.
I'm usually reluctant to assign a cause to short-run hashrate changes, but you're almost certainly right here, so I think it's fine to leave this. I would qualify 'the exchange rate' though, perhaps 'the BTC-USD exchange rate' or similar?
| Wuille suggests two additions to what metadata is hashed: first, the | ||
| transaction fee is included in the hash in order to ensure hardware | ||
| wallets or offline wallets can be absolutely sure that they aren't | ||
| being tricked into sending excess amounts of money to miners. |
There was a problem hiding this comment.
'excess amounts of money' sounds a little odd to me. I think 'sending excess fees' sounds better.
| transactions in specific ways you might find acceptable (e.g. for | ||
| layer-two protocols). | ||
|
|
||
| Wuille suggests two additions to what metadata is hashed: first, the |
There was a problem hiding this comment.
I think you could make it clearer that these would be optional sighash flags (ie the data you refer to below is only included if the flag is present). So change 'what metadata is hashed' to 'what metadata can be included in the hash' here, and 'the (transaction fee|scriptPubKey of the coins being spent) is included' to 'the (...) can be included' below.
There was a problem hiding this comment.
Thanks for changing this. I didn't include my rationale for wanting this to be more explicit. I wanted it to be clear that users wouldn't need to update all of their signing software if this change was introduced.
harding
force-pushed
the
2018-11-27-newsletter
branch
from
292e8c6 to
5182591
Compare
|
Pushed update (force push as GitHub now provides diffs for those) that should resolve nits. Thanks for the review! @practicalswift I'm happy to receive nits for extra whitespace at ends of lines and excessive newlines. I think either one or two spaces after full stops are fine even with a single author (and allowing them makes accepting contributions from multiple authors much easier). |
|
tested ACK 5182591. Thanks! |
|
utACK. Made a minor typo fix. |
jnewbery
force-pushed
the
2018-11-27-newsletter
branch
from
dee04b9 to
7d774b7
Compare
|
Squashed @moneyball's commit and merged. Thanks all! |
Newsletters: add #23 (2018-11-27)
Newsletter bitcoinops#91 incorrectly referred to sighash_noinput as BIP116 instead of BIP118.
* newsletter283zh * fix style * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> * fix link --------- Co-authored-by: editor-Ajian <[email protected]> Co-authored-by: Zhiwei(Jeffrey) Hu <[email protected]> Co-authored-by: freeyao <[email protected]>
* newsletter283zh * fix style * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> * fix link --------- Co-authored-by: editor-Ajian <[email protected]> Co-authored-by: Zhiwei(Jeffrey) Hu <[email protected]> Co-authored-by: freeyao <[email protected]>
4 participants
No description provided.