Skip to content

Conversation

@gujjwal00
Copy link
Contributor

@gujjwal00 gujjwal00 commented Feb 15, 2020

This PR enables rotations of VncCanvasActivity with custom configuration handling.

In addition to orientation we also needs to handle screenSize & screenLayout to avoid restart.
Reference: https://developer.android.com/guide/topics/manifest/activity-element.html#config

Depends on: #47 , #48

We can handle the case of activity being killed in background after #46.

@bk138
Copy link
Owner

bk138 commented Feb 23, 2020

Thanks for the PR! What Activity kill are you referring to? Seems pretty stable with this commit...

@gujjwal00
Copy link
Contributor Author

Canvas activity can killed by the OS when it is in background. Ex:

  1. User connects to VNC server.
  2. While using the app, user receives a call.
  3. Now canvas activity is in background and Android can kill it to free memory.
  4. User finishes the call and navigates back to our app.

Step 2 can be anything that pushes our app to background. If we don't keep the connection alive we have to start everything again in step 4. And if user didn't save the password we have to prompt again.

PS:
VNCConn refactoring is nearly finished. I will submit a PR and you can take a look at it.

@bk138 bk138 self-assigned this Feb 24, 2020
@bk138 bk138 merged commit ccf94f6 into bk138:master Feb 29, 2020
@bk138 bk138 mentioned this pull request Feb 29, 2020
@gujjwal00 gujjwal00 deleted the android-rotation branch February 29, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants