Skip to content

Conversation

@rakita
Copy link
Member

@rakita rakita commented Jun 13, 2024

Introduced here: #1437
Found by @holiman
Fortunately, the bug was not included in Reth or in any release.

Done a few more renames.

@github-actions
Copy link
Contributor

Valgrind Results:

==3923== Cachegrind, a cache and branch-prediction profiler
==3923== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3923== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3923== Command: target/release/snailtracer
==3923== 
--3923-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.801797145s
==3923== 
==3923== I   refs:      426,768,466
==3923== I1  misses:          3,337
==3923== LLi misses:          2,788
==3923== I1  miss rate:        0.00%
==3923== LLi miss rate:        0.00%
==3923== 
==3923== D   refs:      203,975,728  (132,168,113 rd   + 71,807,615 wr)
==3923== D1  misses:        339,877  (    200,237 rd   +    139,640 wr)
==3923== LLd misses:        137,569  (      4,325 rd   +    133,244 wr)
==3923== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3923== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3923== 
==3923== LL refs:           343,214  (    203,574 rd   +    139,640 wr)
==3923== LL misses:         140,357  (      7,113 rd   +    133,244 wr)
==3923== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita
Copy link
Member Author

rakita commented Jun 13, 2024

Slightly older ethereum/tests run locally.
Failure is due to json artefacts not related to PR.

@rakita rakita merged commit 8f99f72 into main Jun 13, 2024
@rakita rakita deleted the rakita/fix_is_cold_reset branch June 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants