Skip to content

fix(revm): remove storage reset that clears is_cold flag #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 2 commits into from
Jun 13, 2024
Merged

fix(revm): remove storage reset that clears is_cold flag #1518

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d4fbd8
fix(revm): remove storage reset that clears is_cold flag
rakita Jun 13, 2024
ae628b6
docs
rakita Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs
  • Loading branch information
@rakita
rakita committed Jun 13, 2024
commit ae628b616e485f641d16c31cd1b487940ab5a3e0
11 changes: 6 additions & 5 deletions crates/revm/src/journaled_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,16 +834,17 @@ pub enum JournalEntry {
/// Actions: Mark account as created
/// Revert: Unmart account as created and reset nonce to zero.
AccountCreated { address: Address },
/// It is used to track both storage change and warm load of storage slot. For warm load in regard
/// to EIP-2929 AccessList had_value will be None
/// Action: Storage change or warm load
/// Revert: Revert to previous value or remove slot from storage
/// Entry used to track storage changes
/// Action: Storage change
/// Revert: Revert to previous value
StorageChanged {
address: Address,
key: U256,
had_value: U256,
},
/// TODO
/// Entry used to track storage warming introduced by EIP-2929.
/// Action: Storage warmed
/// Revert: Revert to cold state
StorageWarmed { address: Address, key: U256 },
/// It is used to track an EIP-1153 transient storage change.
/// Action: Transient storage changed.
Expand Down