Skip to content

Fix move construction of value from object #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdkrystian wants to merge 1 commit into from
Closed

Fix move construction of value from object #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/json/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ class value
object&& other,
storage_ptr sp)
: obj_(
other,
detail::move(other),
detail::move(sp))
{
}
Expand Down
7 changes: 7 additions & 0 deletions test/value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,13 @@ class value_test
BOOST_TEST(jv.is_object());
BOOST_TEST(*jv.storage() == *sp);
}
{
// verify moved from
object obj{{"a", 1}, {"b", 2}};
BOOST_TEST(obj.capacity() > 0);
value jv(std::move(obj), {});
BOOST_TEST(obj.capacity() == 0);
}
}

// value(array)
Expand Down