Fix move construction of value from object #54
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinniefalco
reviewed
Mar 8, 2020
test/value.cpp
Outdated
| } | ||
| { | ||
| // verify moved from | ||
| object obj{{"a", 1}, {"a", 1}}; |
Member
There was a problem hiding this comment.
I would not use duplicate keys
vinniefalco
reviewed
Mar 8, 2020
test/value.cpp
Outdated
| { | ||
| // verify moved from | ||
| object obj{{"a", 1}, {"a", 1}}; | ||
| BOOST_TEST(obj.capacity()); |
Member
There was a problem hiding this comment.
I would not depend on conversion to bool. In other words, spell this out: obj.capacity() > 0
vinniefalco
reviewed
Mar 8, 2020
test/value.cpp
Outdated
| object obj{{"a", 1}, {"a", 1}}; | ||
| BOOST_TEST(obj.capacity()); | ||
| value jv(std::move(obj), {}); | ||
| BOOST_TEST(!obj.capacity()); |
Member
There was a problem hiding this comment.
I would spell this out: obj.capacity() == 0
Codecov Report
@@ Coverage Diff @@
## develop #54 +/- ##
========================================
Coverage 99.09% 99.09%
========================================
Files 57 57
Lines 4854 4855 +1
========================================
+ Hits 4810 4811 +1
Misses 44 44 Continue to review full report at Codecov.
|
sdkrystian
force-pushed
the
value-obj-bug
branch
from
d051adb to
f75ecaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.