Add moving of strings from value_ref, fix value constructor #55
Conversation
|
Tests are failing as these changes are applied separately from #54, will pass once it is applied. |
|
If one commit requires the other then they should be part of the same pull request. One commit per bugfix doesn't mean you have to put each one into its own pull request. |
| // move semantics. | ||
| if (what_ == what::strfunc) | ||
| return *static_cast<const string*>(f_.p); | ||
| else |
There was a problem hiding this comment.
I would lose the else, it reads better
sdkrystian
force-pushed
the
value-ref-string
branch
from
3fad129 to
c60f3d3
Compare
| // nullptr, and capacity returns 0 | ||
| // when the table pointer is null | ||
| array b{std::move(a), object()}; | ||
| BOOST_TEST(a.capacity() == 0); |
There was a problem hiding this comment.
I would remove these comments because they don't provide any additional information
| if(e.what_ != what::str && | ||
| e.what_ != what::strfunc) | ||
| return false; | ||
| return true; |
There was a problem hiding this comment.
Yep this looks much better without the else, as it is absolutely clear that the function ends on line 52
sdkrystian
force-pushed
the
value-ref-string
branch
from
f575416 to
e384f92
Compare
sdkrystian
changed the title
sdkrystian
force-pushed
the
value-ref-string
branch
from
e384f92 to
fdc86db
Compare
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
========================================
Coverage 99.09% 99.09%
========================================
Files 57 57
Lines 4854 4861 +7
========================================
+ Hits 4810 4817 +7
Misses 44 44
Continue to review full report at Codecov.
|
|
Merged, thanks! |
2 participants
No description provided.