Skip to content

Conversation

@StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Jun 26, 2024

Resolves brave/brave-browser#37740

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. In Wallet onboarding, tap Need a new wallet? to create a new wallet
  2. After the legal step, verify you are shown a grid of available networks
  3. Verify you can select / de-select networks (except for Ethereum Mainnet & Solana Mainnet)
  4. Toggle Show Testnets
  5. Verify testnets are shown at bottom of the networks grid
  6. After onboarding, verify an account is created for each network selected during onboarding
    • For Filecoin Testnet and/or Bitcoin Testnet, this should be a separate account for Testnet than the Mainnet account(s)
  7. Open Web3 Settings and tap Networks
  8. Verify the networks selected during onboarding are visible (eye icon)
  9. Verify the networks not selected during onboarding are not visible (crossed out eye icon)
  10. Reset your wallet
  11. In Wallet onboarding, tap Already have a wallet? to restore an existing wallet.
  12. After the legal step, verify you are shown a grid of available networks
  13. Verify you can select / de-select networks (except for Ethereum Mainnet & Solana Mainnet)
  14. Toggle Show Testnets
  15. Verify testnets are shown at bottom of the networks grid
  16. Verify the networks selected during onboarding are visible (eye icon)
  17. Verify the networks not selected during onboarding are not visible (crossed out eye icon)
iPhone networks iPhone networks + testnets
iPhone networks - dark iPhone networks + testnets - dark
iPad networks iPad networks + testnets
iPad networks - dark iPad networks + testnets - dark

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jun 26, 2024
@StephenHeaps StephenHeaps self-assigned this Jun 26, 2024
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch 3 times, most recently from e6e24c5 to dddaae3 Compare July 2, 2024 15:37
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from dddaae3 to 7684cb8 Compare August 6, 2024 16:34
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from 7684cb8 to 2cc44be Compare August 14, 2024 15:48
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@github-actions
Copy link
Contributor

Chromium major version is behind target branch (139.0.7258.127 vs 140.0.7339.16). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Aug 20, 2025
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from 57e2480 to 67a8a9f Compare August 20, 2025 14:41
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Aug 20, 2025
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from 67a8a9f to 1345ec3 Compare September 16, 2025 15:18
@github-actions
Copy link
Contributor

Chromium major version is behind target branch (140.0.7339.133 vs 141.0.7390.30). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Sep 22, 2025
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from 1345ec3 to 6e900b0 Compare October 16, 2025 15:42
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 16, 2025
@StephenHeaps StephenHeaps force-pushed the wallet/networks-onboarding branch from 6e900b0 to 0ae8f80 Compare November 19, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-windows-x64 Do not run CI builds for Windows x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS/Wallet] Network selection in onboarding

4 participants