Skip to content

Display a little more detail about why sync requires chromium update #25824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petemill wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −8
Open

Display a little more detail about why sync requires chromium update #25824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions build/commands/lib/syncUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,34 @@ function shouldUpdateChromium(latestSyncInfo, expectedSyncInfo) {
const chromiumRef = expectedSyncInfo.chromiumRef
const headSHA = util.runGit(config.srcDir, ['rev-parse', 'HEAD'], true)
const targetSHA = util.runGit(config.srcDir, ['rev-parse', chromiumRef], true)
const needsUpdate =
targetSHA !== headSHA ||
(!headSHA && !targetSHA) ||
JSON.stringify(latestSyncInfo) !== JSON.stringify(expectedSyncInfo)
let needsUpdate = false
let updateReason = ''
if (targetSHA !== headSHA) {
needsUpdate = true
updateReason = 'a different target commit'
}
if (!headSHA && !targetSHA) {
needsUpdate = true
updateReason = 'missing commit information'
}
if (JSON.stringify(latestSyncInfo) !== JSON.stringify(expectedSyncInfo)) {
needsUpdate = true
updateReason = `differences with the expected sync metadata of: ${
JSON.stringify(expectedSyncInfo, null, 4)}`
}

if (needsUpdate) {
const currentRef = util.getGitReadableLocalRef(config.srcDir)
console.log(
`Chromium repo ${chalk.blue.bold(
'needs sync'
)}.\n target is ${chalk.italic(chromiumRef)} at commit ${
`needs sync due to ${chalk.italic(updateReason)}`
)}.\n - target is ${chalk.italic(chromiumRef)} at commit ${
targetSHA || '[missing]'
}\n current commit is ${chalk.italic(
}\n - current commit is ${chalk.italic(
currentRef || '[unknown]'
)} at commit ${chalk.inverse(
headSHA || '[missing]'
)}\n latest successful sync is ${JSON.stringify(
)}\n - last successful sync metadata is ${JSON.stringify(
latestSyncInfo,
null,
4
Expand Down