Re-enable linking to # on data page #1796
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyhgrant
force-pushed
the
reenable-data-page-scrolling
branch
from
9510e30 to
8f1472e
Compare
rileyhgrant
force-pushed
the
reenable-data-page-scrolling
branch
from
8f1472e to
f6dcc53
Compare
phildarnowsky-broad
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1793
As best I can tell, changes in rendering of the DOM in react 18 broke the scroll to an anchor tag id behavior that let us link to a given section on the data page. Linking to a specific section is used extensively in blog posts, and elsewhere.
This PR adds a tiny
useEffecthook to the data page to snoop on the hash and scroll to it, to re-enable the behavior.