Migrate to androix #47
Conversation
martinbonnin
force-pushed
the
migrate-to-androix
branch
from
8c4aaf4 to
de2bb01
Compare
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 53.62%
Complexity ? 19
=========================================
Files ? 9
Lines ? 69
Branches ? 3
=========================================
Hits ? 37
Misses ? 28
Partials ? 4
Continue to review full report at Codecov.
|
| testImplementation cacheTestDependencies.junit | ||
| testImplementation cacheTestDependencies.kotlinJUnit | ||
| testImplementation cacheTestDependencies.mockito | ||
| testImplementation cacheTestDependencies.kotlinReflect |
There was a problem hiding this comment.
I do not think that this library is necessary. Just curious - why did you add it in every module?
There was a problem hiding this comment.
This is so long ago, I'm not sure any more... Maybe it has to do with a gradle warning saying that different versions of a lib were found on the classpath. Maybe it's something else. Feel free to remove it. If it works well then I guess it's not needed !
| testingSupportLibVersion = '0.1' | ||
| mockitoKotlinVersion = '1.5.0' | ||
| mockitoAndroidVersion = '2.8.47' | ||
| mockitoAndroidVersion = '2.8.9' // As of today, 2.23.0 does not work |
| androidAnnotations: "androidx.annotation:annotation:1.0.0", | ||
| appCompat: "androidx.appcompat:appcompat:${appCompatVersion}", | ||
| supportRecyclerView:"androidx.recyclerview:recyclerview:1.0.0", | ||
| supportDesign: "com.google.android.material:material:1.0.0-rc01", |
There was a problem hiding this comment.
I am pretty sure that when you use supportDesign library you don't need to add supportRecyclerView.
| @@ -1,3 +1,7 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
What is purpose of this plugin? Is it related to Migrate to androidX MR?
There was a problem hiding this comment.
It's used to check if new versions of libraries are available. No needed for androidx. You can skip it.
|
Closing due to inactivity |
1 participant
This PR migrates to AndroidX and Android Studio 3.2.1.
It also adds the gradle-versions-plugin and bumps several libraries to their latest version