-
Notifications
You must be signed in to change notification settings - Fork 515
Migrate to androix #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1288aee
make it compile with AS 3.2.1
martinbonnin 5d2bef6
migrate to androidx
martinbonnin 06ad857
trying to unbreak travis
martinbonnin f698320
simplify travis.yaml
martinbonnin 94e8ad1
remove legacy appcompat, hopefull fix travis
martinbonnin 973e2eb
use dependencies from dependencies.gradle
martinbonnin 1537ebe
more debug info
martinbonnin 7f6ea11
force the kotlin-reflect:1.2 dependency for all modules
martinbonnin 443b995
use the same appcompat everywhere
martinbonnin de2bb01
add gradle.properties to git
martinbonnin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
migrate to androidx
- Loading branch information
commit 5d2bef6150222012dbf91ad09862a007f3142eb2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,24 +2,23 @@ | |
| ext { | ||
| //Android | ||
| androidMinSdkVersion = 15 | ||
| androidTargetSdkVersion = 26 | ||
| androidCompileSdkVersion = 26 | ||
| androidTargetSdkVersion = 28 | ||
| androidCompileSdkVersion = 28 | ||
|
|
||
| //Libraries | ||
| kotlinVersion = '1.1.3-2' | ||
| rxKotlinVersion = '2.1.0' | ||
| rxAndroidVersion = '2.0.1' | ||
| kotlinVersion = '1.2.71' | ||
| rxKotlinVersion = '2.3.0' | ||
| rxAndroidVersion = '2.1.0' | ||
| javaxAnnotationVersion = '1.0' | ||
| javaxInjectVersion = '1' | ||
| gsonVersion = '2.8.1' | ||
| okHttpVersion = '3.8.1' | ||
| androidAnnotationsVersion = '21.0.3' | ||
| retrofitVersion = '2.3.0' | ||
| roomVersion = '1.0.0-alpha6' | ||
| supportLibraryVersion = '26.0.1' | ||
| timberVersion = '4.5.1' | ||
| glideVersion = '4.0.0' | ||
| daggerVersion = '2.11' | ||
| timberVersion = '4.7.1' | ||
| glideVersion = '4.8.0' | ||
| daggerVersion = '2.16' // As of today, 2.17 does not work. See https://issuetracker.google.com/issues/115738511 | ||
| glassfishAnnotationVersion = '10.0-b28' | ||
|
|
||
| //Testing | ||
|
|
@@ -31,7 +30,7 @@ ext { | |
| espressoVersion = '3.0.0' | ||
| testingSupportLibVersion = '0.1' | ||
| mockitoKotlinVersion = '1.5.0' | ||
| mockitoAndroidVersion = '2.8.47' | ||
| mockitoAndroidVersion = '2.8.9' // As of today, 2.23.0 does not work | ||
| androidSupportRunnerVersion = '1.0.0' | ||
| androidSupportRulesVersion = '1.0.0' | ||
| dexmakerMockitoversion = '2.2.0' | ||
|
|
@@ -41,7 +40,7 @@ ext { | |
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}" | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}" | ||
| ] | ||
|
|
||
| domainTestDependencies = [ | ||
|
|
@@ -57,7 +56,7 @@ ext { | |
| okHttpLogger: "com.squareup.okhttp3:logging-interceptor:${okHttpVersion}", | ||
| gson: "com.google.code.gson:gson:${gsonVersion}", | ||
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}", | ||
| rxAndroid: "io.reactivex.rxjava2:rxandroid:${rxAndroidVersion}", | ||
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
|
|
@@ -82,7 +81,7 @@ ext { | |
| okHttpLogger: "com.squareup.okhttp3:logging-interceptor:${okHttpVersion}", | ||
| gson: "com.google.code.gson:gson:${gsonVersion}", | ||
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}", | ||
| rxAndroid: "io.reactivex.rxjava2:rxandroid:${rxAndroidVersion}", | ||
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
|
|
@@ -105,7 +104,7 @@ ext { | |
| dagger: "com.google.dagger:dagger:${daggerVersion}", | ||
| gson: "com.google.code.gson:gson:${gsonVersion}", | ||
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}", | ||
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
| androidAnnotations: "com.android.support:support-annotations:${androidAnnotationsVersion}", | ||
|
|
@@ -131,7 +130,7 @@ ext { | |
| dagger: "com.google.dagger:dagger:${daggerVersion}", | ||
| gson: "com.google.code.gson:gson:${gsonVersion}", | ||
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}", | ||
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
| androidAnnotations: "com.android.support:support-annotations:${androidAnnotationsVersion}", | ||
|
|
@@ -157,15 +156,13 @@ ext { | |
| rxKotlin: "io.reactivex.rxjava2:rxkotlin:${rxKotlinVersion}", | ||
| rxAndroid: "io.reactivex.rxjava2:rxandroid:${rxAndroidVersion}", | ||
| glide: "com.github.bumptech.glide:glide:${glideVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jre8:${kotlinVersion}", | ||
| kotlin: "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${kotlinVersion}", | ||
| javaxAnnotation: "javax.annotation:jsr250-api:${javaxAnnotationVersion}", | ||
| javaxInject: "javax.inject:javax.inject:${javaxInjectVersion}", | ||
| androidAnnotations: "com.android.support:support-annotations:${supportLibraryVersion}", | ||
| androidSupportV4: "com.android.support:support-v4:${supportLibraryVersion}", | ||
| androidSupportV13: "com.android.support:support-v13:${supportLibraryVersion}", | ||
| appCompatV7: "com.android.support:appcompat-v7:${supportLibraryVersion}", | ||
| supportRecyclerView:"com.android.support:recyclerview-v7:${supportLibraryVersion}", | ||
| supportDesign: "com.android.support:design:${supportLibraryVersion}", | ||
| androidAnnotations: "androidx.annotation:annotation:1.0.0", | ||
| appCompat: "androidx.appcompat:appcompat:1.0.0", | ||
| supportRecyclerView:"androidx.recyclerview:recyclerview:1.0.0", | ||
| supportDesign: "com.google.android.material:material:1.0.0-rc01", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am pretty sure that when you use |
||
| timber: "com.jakewharton.timber:timber:${timberVersion}", | ||
| daggerSupport: "com.google.dagger:dagger-android-support:${daggerVersion}", | ||
| daggerProcessor: "com.google.dagger:dagger-android-processor:${daggerVersion}", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 7 additions & 7 deletions
14
...le-ui/src/androidTest/java/org/buffer/android/boilerplate/ui/browse/BrowseActivityTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
mobile-ui/src/main/java/org/buffer/android/boilerplate/ui/browse/BrowseActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
mobile-ui/src/main/java/org/buffer/android/boilerplate/ui/browse/BrowseAdapter.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downgraded library?