Skip to content

Conversation

@brendandburns
Copy link
Contributor

  • This is related to [WIP] Add a wasi-http support as a module #5678 there's a dependency mis-match that between some libraries I need for HTTP and the (old) base64 crate in wasmtime.
  • Revs the base64 dependency to 0.21.0, small API change.
  • This PR contains test cases, if meaningful. Not necessary, covered by existing tests.

@brendandburns brendandburns changed the title Deps Update base64 dependency to 0.21.0 Feb 3, 2023
@pchickey
Copy link
Contributor

pchickey commented Feb 3, 2023

Agree we should update this dep, but I need to learn how to use cargo vet to generate the correct sort of record for the diff. I'll do my best to take care of that before eod. Our project policy is that only core contributors are trusted to vet packages, but I have never actually done it myself since that policy was set a few months ago.

@pchickey
Copy link
Contributor

pchickey commented Feb 4, 2023

Please rebase on main after #5707 merges, and remove the last commit modifying the vet toml. Thanks!

@brendandburns
Copy link
Contributor Author

@pchickey rebased, thanks for taking care of the vet part.

@brendandburns
Copy link
Contributor Author

So, I dropped my cargo vet related commit, perhaps I wasn't supposed to do that? Anyway, I'm still seeing this cargo vet error:

Run cargo vet --locked
Vetting Failed!

1 unvetted dependencies:
  base64:0.21.0 missing ["safe-to-deploy"]
Error: Process completed with exit code 255.

Let me know the right way to fix this.

Thanks!

@pchickey
Copy link
Contributor

pchickey commented Feb 5, 2023

Nope, thats me making a mistake on the vetting. I'll fix it

@pchickey
Copy link
Contributor

pchickey commented Feb 5, 2023

#5710 will fix the vet problem, someone will review it monday. Sorry!

@pchickey
Copy link
Contributor

pchickey commented Feb 6, 2023

I checked a rebase on main locally and this should be fixed now

@peterhuene peterhuene enabled auto-merge (squash) February 7, 2023 04:01
@peterhuene peterhuene merged commit 08403c9 into bytecodealliance:main Feb 7, 2023
@brendandburns
Copy link
Contributor Author

Thanks @pchickey for the fixes and @peterhuene for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants