Cargo update cap-std family, and audit deps #5710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2023
cfallin
approved these changes
Feb 5, 2023
sunfishcode
reviewed
Feb 6, 2023
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
fd-lock 3.0.10 is now released with the update to windows-sys 0.45.
| [[audits.base64]] | ||
| who = "Pat Hickey <[email protected]>" | ||
| criteria = "safe-to-run" | ||
| criteria = "safe-to-deploy" |
Member
There was a problem hiding this comment.
It's my understanding that cargo-vet audits are meant to be "append only", so we should add a new entry for safe-to-deploy rather than modifying the existing entry.
Contributor
Author
There was a problem hiding this comment.
Ok, I fixed this by making another entry.
added 2 commits
February 6, 2023 09:28
I mistakenly marked it safe-to-run not understanding that safe-to-deploy was required.
eliminates duplicate dep on windows-sys
pchickey
force-pushed
the
pch/update_cap_std_openoptions
branch
from
965bc8f to
344e4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the whole
cap-stdfamily to their latest releases, so that I can (in an upcoming PR) add wasi-common support for opening with sync family of fdflags by way of bytecodealliance/cap-std#292.I did the cargo vet diff audit this time, and it was pretty straightforward.