Rename define_function to define_function_with_control_plane #6165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
bjorn3
force-pushed
the
define_function_ergonomics
branch
4 times, most recently
from
5662fdc to
9ab5378
Compare
github-actions
bot
added
cranelift
And add a define_function convenience function which uses a default control plane.
bjorn3
force-pushed
the
define_function_ergonomics
branch
from
9ab5378 to
9c2360b
Compare
Contributor
Author
|
The riscv64 test job has been running for almost an hour now while CI normally finishes within 40 minutes: https://github.com/bytecodealliance/wasmtime/actions/runs/4630900109/jobs/8193094544 Maybe it is stuck? |
brendandburns
pushed a commit
to brendandburns/wasmtime
that referenced
this pull request
Apr 13, 2023
…ealliance#6165) And add a define_function convenience function which uses a default control plane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a define_function convenience function which uses a default control plane.