Don't override declare_*_in_func in cranelift-jit #6169
Merged
+15
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Instead remove the colocated flag for hotplug mode in define_function. This prevents issues if declare_*_in_func wasn't used due to eg the function being from a previously serialized module and now deserialized into JITModule.
bjorn3
force-pushed
the
bsc-unwinding-jit-no-override
branch
from
70ba0f2 to
390246b
Compare
Contributor
Author
|
Rebased |
brendandburns
pushed a commit
to brendandburns/wasmtime
that referenced
this pull request
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead remove the colocated flag for hotplug mode in define_function. This prevents issues if declare_*_in_func wasn't used due to eg the function being from a previously serialized module and now deserialized into JITModule.
Based on #6165 to prevent merge conflicts. Will rebase once it lands.