fix: log ERROR ActivityLog when reporting Health.down#7125
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts inbound connector health-change activity logging so that health transitions are categorized with an explicit severity: INFO when the connector reports Health.up(), and ERROR for any other health status. It also extends the existing unit test suite to verify the new severity behavior.
Changes:
- Set
Activity.severitytoINFOforHealth.Status.UP, otherwiseERROR, whenInboundConnectorContextImpl.reportHealth(...)logs a health change. - Add unit tests ensuring the correct severity is written to the activity log for both
Health.up()andHealth.down().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| connector-runtime/connector-runtime-core/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java | Assigns severity based on health status when emitting the HEALTH activity entry. |
| connector-runtime/connector-runtime-core/src/test/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImplTest.java | Adds assertions that reportHealth(...) logs INFO for UP and ERROR for DOWN. |
ztefanie
approved these changes
May 5, 2026
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
johnBgood
added a commit
that referenced
this pull request
May 5, 2026
johnBgood
added a commit
that referenced
this pull request
May 5, 2026
Contributor
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
Contributor
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the way health status changes are logged in the inbound connector context by introducing severity levels to activity logs. It also adds comprehensive tests to ensure the correct severity is set based on the health status.
Activity log severity improvements:
reportHealthmethod inInboundConnectorContextImplnow logs health status changes with a severity level:INFOforUPstatus andERRORfor other statuses.Testing enhancements:
InboundConnectorContextImplTestto verify that the correct severity (INFOorERROR) is set in the activity log when reporting health status changes.ActivityLogTag,Health,Severity) in the test file to support the new tests.Checklist
release, as this branch will be rebased onto main before the next release. Example backport labels:
backport stable/8.8: for changes that should be included in the next 8.8.x release.backport release-8.8.7: for changes that should be included in the specific release 8.8.7, and thisrelease has already been created. The release branch will be merged back into stable/8.8 later, so the change
will be included in future 8.8.x releases as well.