Skip to content

fix: log ERROR ActivityLog when reporting Health.down #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnBgood merged 1 commit into from
May 5, 2026
+54 −0
Merged

fix: log ERROR ActivityLog when reporting Health.down #7125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: log ERROR ActivityLog when reporting Health.down
  • Loading branch information
@johnBgood
johnBgood committed May 4, 2026
commit ce6d6add3a01920032f2f3ea751da3873ba252ef
1 change: 1 addition & 0 deletions .../src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ public void reportHealth(Health health) {
String.format(
"Health status changed to %s, details: %s",
health.getStatus(), health.getDetails()))
.withSeverity(health.getStatus() == Health.Status.UP ? Severity.INFO : Severity.ERROR)
.andReportHealth(health)
.build();
// append the activity log to store the health status change history
Expand Down
53 changes: 53 additions & 0 deletions .../test/java/io/camunda/connector/runtime/core/inbound/InboundConnectorContextImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import io.camunda.connector.api.annotation.FEEL;
import io.camunda.connector.api.inbound.ActivityLogTag;
import io.camunda.connector.api.inbound.Health;
import io.camunda.connector.api.inbound.Severity;
import io.camunda.connector.api.secret.SecretProvider;
import io.camunda.connector.runtime.core.FooBarSecretProvider;
import io.camunda.connector.runtime.core.TestObjectMapperSupplier;
Expand Down Expand Up @@ -155,6 +158,56 @@ void getProperties_shouldNotParseFeel() {
assertThat(properties.get("stringMap")).isEqualTo("={\"keyString\":null}");
}

@Test
void reportHealth_shouldLogInfoSeverityWhenStatusIsUp() {
// given
var definition = getInboundConnectorDefinition(Map.of());
var health = Health.up();
InboundConnectorContextImpl inboundConnectorContext =
new InboundConnectorContextImpl(
secretProvider, (e) -> {}, definition, null, (e) -> {}, mapper, activityLogRegistry);

// when
inboundConnectorContext.reportHealth(health);

// then
var logs =
activityLogRegistry.getLogs(ExecutableId.fromDeduplicationId(definition.deduplicationId()));
assertThat(logs)
.singleElement()
.satisfies(
log -> {
assertThat(log.tag()).isEqualTo(ActivityLogTag.HEALTH);
assertThat(log.healthChange()).isEqualTo(health);
assertThat(log.severity()).isEqualTo(Severity.INFO);
});
}

@Test
void reportHealth_shouldLogErrorSeverityWhenStatusIsDown() {
// given
var definition = getInboundConnectorDefinition(Map.of());
var health = Health.down();
InboundConnectorContextImpl inboundConnectorContext =
new InboundConnectorContextImpl(
secretProvider, (e) -> {}, definition, null, (e) -> {}, mapper, activityLogRegistry);

// when
inboundConnectorContext.reportHealth(health);

// then
var logs =
activityLogRegistry.getLogs(ExecutableId.fromDeduplicationId(definition.deduplicationId()));
assertThat(logs)
.singleElement()
.satisfies(
log -> {
assertThat(log.tag()).isEqualTo(ActivityLogTag.HEALTH);
assertThat(log.healthChange()).isEqualTo(health);
assertThat(log.severity()).isEqualTo(Severity.ERROR);
});
}

private TestPropertiesClass createTestClass() {
TestPropertiesClass testClass = new TestPropertiesClass();
testClass.setStringMap(Map.of("keyString", "valueString"));
Expand Down
Loading