fix(etg): Ignore static fields by ztefanie · Pull Request #7143 · camunda/connectors

ztefanie · 2026-05-06T11:11:15Z

Description

Remove static fields from ETG. Only affected connector is microsoft team, which had this one property added, which was never displayed as the condition could not be true (wrong order).

Checklist

Backport labels are added if these code changes should be backported. No backport label is added to the latest
release, as this branch will be rebased onto main before the next release. Example backport labels:
- backport stable/8.8: for changes that should be included in the next 8.8.x release.
- or backport release-8.8.7: for changes that should be included in the specific release 8.8.7, and this
  release has already been created. The release branch will be merged back into stable/8.8 later, so the change
  will be included in future 8.8.x releases as well.
Tests/Integration tests for the changes have been added if applicable.
If the change requires a documentation update, it has been added to the appropriate section in the documentation.

CLAassistant · 2026-05-06T11:11:25Z

All committers have signed the CLA.

Copilot

Pull request overview

This PR updates the Element Template Generator’s reflection-based field discovery to ignore static fields, and regenerates the Microsoft Teams outbound connector templates to drop a previously (incorrectly) generated static-field property.

Changes:

Filter static fields out of ReflectionUtil.getAllFields(...) to prevent ETG from turning constants into template inputs.
Remove the generated data.EXPAND_VALUE property from the current Microsoft Teams outbound template and its hybrid variant.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
connectors/microsoft/teams/element-templates/microsoft-teams-outbound-connector.json	Removes the previously generated `data.EXPAND_VALUE` template property from the current (non-hybrid) Teams template.
connectors/microsoft/teams/element-templates/hybrid/microsoft-teams-outbound-connector-hybrid.json	Removes the same property from the hybrid Teams template.
connector-commons/connector-utils/src/main/java/io/camunda/connector/util/reflection/ReflectionUtil.java	Updates field collection logic to exclude static fields (affects ETG property extraction).

…clusion Agent-Logs-Url: https://github.com/camunda/connectors/sessions/e4889c61-820b-44f1-8e39-726a679906b6 Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com>

…late properties Agent-Logs-Url: https://github.com/camunda/connectors/sessions/69104d6f-81e2-4acc-a69a-7987aa2dd56e Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com>

johnBgood · 2026-05-11T14:13:13Z

@ztefanie should we backport this?

ztefanie · 2026-05-12T09:20:55Z

@ztefanie should we backport this?

I can backport it sure, but we only run etg on main right? So this should not be needed.

johnBgood · 2026-05-12T09:37:09Z

@ztefanie should we backport this?

I can backport it sure, but we only run etg on main right? So this should not be needed.

Can't our customers use it as well?

ztefanie · 2026-05-12T09:44:31Z

Yes true 👍

team-connectors-int-automation · 2026-05-12T10:42:57Z

Backport failed for stable/8.7, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.7
git worktree add -d .worktree/backport-7143-to-stable/8.7 origin/stable/8.7
cd .worktree/backport-7143-to-stable/8.7
git switch --create backport-7143-to-stable/8.7
git cherry-pick -x 292dc7650f25193c87caa43d98860b612b84c157

team-connectors-int-automation · 2026-05-12T10:43:00Z

Backport failed for stable/8.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.8
git worktree add -d .worktree/backport-7143-to-stable/8.8 origin/stable/8.8
cd .worktree/backport-7143-to-stable/8.8
git switch --create backport-7143-to-stable/8.8
git cherry-pick -x 292dc7650f25193c87caa43d98860b612b84c157

team-connectors-int-automation · 2026-05-12T10:43:05Z

Successfully created backport PR for stable/8.9:

[Backport stable/8.9] fix(etg): Ignore static fields #7190

* fix(etg): Ignore static fields * fix(etg): update JavaDoc for getAllFields to document static field exclusion Agent-Logs-Url: https://github.com/camunda/connectors/sessions/e4889c61-820b-44f1-8e39-726a679906b6 Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com> * test(etg): add test to verify static fields are not generated as template properties Agent-Logs-Url: https://github.com/camunda/connectors/sessions/69104d6f-81e2-4acc-a69a-7987aa2dd56e Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com> * Update ReflectionUtil.java --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> (cherry picked from commit 292dc76)

* fix(etg): Ignore static fields * fix(etg): update JavaDoc for getAllFields to document static field exclusion Agent-Logs-Url: https://github.com/camunda/connectors/sessions/e4889c61-820b-44f1-8e39-726a679906b6 Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com> * test(etg): add test to verify static fields are not generated as template properties Agent-Logs-Url: https://github.com/camunda/connectors/sessions/69104d6f-81e2-4acc-a69a-7987aa2dd56e Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com> * Update ReflectionUtil.java --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

fix(etg): Ignore static fields

ced2924

Copilot AI review requested due to automatic review settings May 6, 2026 11:11

ztefanie requested a review from a team as a code owner May 6, 2026 11:11

ztefanie requested a review from chillleader May 6, 2026 11:11

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread ...mmons/connector-utils/src/main/java/io/camunda/connector/util/reflection/ReflectionUtil.java

Comment thread ...mmons/connector-utils/src/main/java/io/camunda/connector/util/reflection/ReflectionUtil.java

Copilot started work on behalf of ztefanie May 6, 2026 11:17 View session

fix(etg): update JavaDoc for getAllFields to document static field ex…

bc75f1a

…clusion Agent-Logs-Url: https://github.com/camunda/connectors/sessions/e4889c61-820b-44f1-8e39-726a679906b6 Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com>

Copilot finished work on behalf of ztefanie May 6, 2026 11:20

Copilot started work on behalf of ztefanie May 6, 2026 11:20 View session

Copilot finished work on behalf of ztefanie May 6, 2026 11:29

github-advanced-security AI found potential problems May 7, 2026

View reviewed changes

Comment thread ...c/test/java/io/camunda/connector/generator/java/OutboundClassBasedTemplateGeneratorTest.java Dismissed

Comment thread .../src/test/java/io/camunda/connector/generator/java/example/outbound/MyConnectorFunction.java Fixed

ztefanie force-pushed the fix/etg-skip-static-fields branch 2 times, most recently from da93bc0 to c481391 Compare May 7, 2026 10:20

ztefanie marked this pull request as draft May 7, 2026 11:15

ztefanie force-pushed the fix/etg-skip-static-fields branch 3 times, most recently from 9bd9cf4 to 1975b18 Compare May 7, 2026 11:19

Update ReflectionUtil.java

075c1a7

ztefanie force-pushed the fix/etg-skip-static-fields branch from 1975b18 to 075c1a7 Compare May 7, 2026 11:22

ztefanie marked this pull request as ready for review May 7, 2026 12:31

johnBgood approved these changes May 11, 2026

View reviewed changes

chillleader approved these changes May 12, 2026

View reviewed changes

ztefanie added backport stable/8.7 backport stable/8.8 labels May 12, 2026

ztefanie added the backport stable/8.9 label May 12, 2026

ztefanie added this pull request to the merge queue May 12, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 12, 2026

ztefanie added this pull request to the merge queue May 12, 2026

Merged via the queue into main with commit 292dc76 May 12, 2026
64 checks passed

ztefanie deleted the fix/etg-skip-static-fields branch May 12, 2026 10:42

team-connectors-int-automation Bot mentioned this pull request May 12, 2026

[Backport stable/8.9] fix(etg): Ignore static fields #7190

Merged

This was referenced May 12, 2026

fix(etg): Ignore static fields (#7143) #7191

Merged

fix(etg): Ignore static fields (#7143) #7192

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(etg): Ignore static fields#7143

fix(etg): Ignore static fields#7143
ztefanie merged 4 commits into
mainfrom
fix/etg-skip-static-fields

ztefanie commented May 6, 2026

Uh oh!

CLAassistant commented May 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnBgood commented May 11, 2026

Uh oh!

ztefanie commented May 12, 2026

Uh oh!

johnBgood commented May 12, 2026

Uh oh!

ztefanie commented May 12, 2026

Uh oh!

Uh oh!

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

ztefanie commented May 6, 2026

Description

Checklist

Uh oh!

CLAassistant commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnBgood commented May 11, 2026

Uh oh!

ztefanie commented May 12, 2026

Uh oh!

johnBgood commented May 12, 2026

Uh oh!

ztefanie commented May 12, 2026

Uh oh!

Uh oh!

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

team-connectors-int-automation Bot commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CLAassistant commented May 6, 2026 •

edited

Loading