Skip to content

fix(etg): Ignore static fields #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ztefanie merged 4 commits into from
May 12, 2026
Merged

fix(etg): Ignore static fields #7143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ced2924
fix(etg): Ignore static fields
ztefanie May 6, 2026
bc75f1a
fix(etg): update JavaDoc for getAllFields to document static field ex…
Copilot May 6, 2026
03eac28
test(etg): add test to verify static fields are not generated as temp…
Copilot May 6, 2026
075c1a7
Update ReflectionUtil.java
ztefanie May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(etg): add test to verify static fields are not generated as temp… 
…late properties

Agent-Logs-Url: https://github.com/camunda/connectors/sessions/69104d6f-81e2-4acc-a69a-7987aa2dd56e

Co-authored-by: ztefanie <18463686+ztefanie@users.noreply.github.com>
  • Loading branch information
@ztefanie
Copilot and ztefanie authored May 6, 2026
commit 03eac28e60172d852ee219757cf58fef46edd4b8
12 changes: 12 additions & 0 deletions ...est/java/io/camunda/connector/generator/java/OutboundClassBasedTemplateGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import io.camunda.connector.generator.dsl.ElementTemplate.ElementTypeWrapper;
import io.camunda.connector.generator.dsl.HiddenProperty;
import io.camunda.connector.generator.dsl.NumberProperty;
import io.camunda.connector.generator.dsl.Property;
import io.camunda.connector.generator.dsl.PropertyBinding;
import io.camunda.connector.generator.dsl.PropertyBinding.ZeebeInput;
import io.camunda.connector.generator.dsl.PropertyBinding.ZeebeTaskDefinition;
Expand Down Expand Up @@ -640,6 +641,17 @@ void supportsExtensionProperties() {
assertThat(p.getCondition()).isEqualTo(new Equals("booleanProperty", false));
});
}

@Test
void staticFields_areNotGeneratedAsProperties() {
var template =
generator.generate(MyConnectorFunction.WithStaticFields.class).getFirst();
var propertyIds =
template.properties().stream().map(Property::getId).collect(Collectors.toSet());
Comment thread
ztefanie marked this conversation as resolved.
Dismissed

assertThat(propertyIds).contains("instanceField");
assertThat(propertyIds).doesNotContain("STATIC_CONSTANT");
}
}

@Nested
Expand Down
12 changes: 12 additions & 0 deletions ...c/test/java/io/camunda/connector/generator/java/example/outbound/MyConnectorFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,18 @@ public static class MinimallyAnnotatedWithPngIcon extends MyConnectorFunction {}
icon = "my-connector-icon.png")
public static class WithDuplicatePropertyIds extends MyConnectorFunction {}

@OutboundConnector(name = "my-connector", type = "my-connector-type")
@ElementTemplate(
engineVersion = "^8.7",
id = MyConnectorFunction.ID,
name = MyConnectorFunction.NAME,
inputDataClass = StaticFieldInput.class)
public static class WithStaticFields extends MyConnectorFunction {
record StaticFieldInput(String instanceField) {
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
static final String STATIC_CONSTANT = "constant";
}
}

@OutboundConnector(name = "my-connector", type = "my-connector-type")
@ElementTemplate(
engineVersion = "^8.7",
Expand Down