Fix generateTicks when working with tiny numbers #5948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@kurkle What would be the best way to test this? |
Member
Author
Added a simple test for the specific issue. |
Contributor
|
@kurkle can you rebase this PR against master? |
kurkle
force-pushed
the
#5932
branch
2 times, most recently
from
10c36c2 to
38dc932
Compare
benmccann
reviewed
Jan 1, 2019
benmccann
reviewed
Jan 2, 2019
benmccann
previously approved these changes
Jan 2, 2019
Member
Author
|
After discussing this with @simonbrunel, found a much cleaner solution. |
benmccann
reviewed
Jan 3, 2019
benmccann
reviewed
Jan 3, 2019
benmccann
previously approved these changes
Jan 3, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kurkle
changed the title
simonbrunel
reviewed
Jan 3, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
benmccann
reviewed
Jan 3, 2019
benmccann
reviewed
Jan 3, 2019
Member
Author
|
rebased |
simonbrunel
approved these changes
Jan 8, 2019
etimberg
approved these changes
Jan 9, 2019
nagix
approved these changes
Jan 9, 2019
Member
|
Thanks @kurkle |
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jsfiddle.net/eg3894u5/3/ Update: http://jsfiddle.net/eg3894u5/4/ Another update: http://jsfiddle.net/eg3894u5/5/ Sanitizing v1: http://jsfiddle.net/eg3894u5/6/ Latest version: http://jsfiddle.net/eg3894u5/7/https://codepen.io/kurkle/pen/WLzeJM (9b69423)
Fixes: #5932