Skip to content

Fix generateTicks when working with tiny numbers #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Fix generateTicks when working with tiny numbers #5948

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
79b261f
increase spacing until there is a range
kurkle Jan 1, 2019
fe1c1f3
add comment
kurkle Jan 1, 2019
6a43dfa
extra newline removed
kurkle Jan 3, 2019
f6c9fa7
2 points is enough
kurkle Jan 3, 2019
e70c334
save a line
kurkle Jan 3, 2019
48314ed
another solution
kurkle Jan 3, 2019
dbfe1b5
use variables instead of changing dataRange,apply a lower bound to sp…
kurkle Jan 3, 2019
363c295
spacing < MIN_SPACING
kurkle Jan 4, 2019
ef226c7
requested changes
kurkle Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
save a line
  • Loading branch information
@kurkle
kurkle committed Jan 7, 2019
commit e70c33436f86c02142eb60f99d2c8f8e26539d3f
3 changes: 1 addition & 2 deletions src/scales/scale.linearbase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ function generateTicks(generationOptions, dataRange) {
if (niceMin === niceMax) {
// This happens due to float inccuracy when min and max are really close to each other
// One case: min = 1.8548483304974972 and max = 1.8548483304974974
ticks.push(dataRange.min, dataRange.max);
return ticks;
return [dataRange.min, dataRange.max];
}

// If min, max and stepSize is set and they make an evenly spaced scale use it.
Expand Down