remove: partial downloads (remove creation of the stub messages)

[Simon-Laux]

• remove code for partial downloads
• remove tests for partial downloads and make a list of them so we can discuss if we need to re-add some in the new system or not
• make download full message methods fail for now with not implemented error and comment what should happen later doesn't need to change at this time (and possibly not at all)

I kept partial_download_msg_body stock string for now, as it may be reused in the new solution. because I made the linter ignore it, I added a to do item to #7367 to check if it was used in the end. edit: outdated, the stock string was removed meanwhile.

removed partial download tests:

• test_reaction_to_partially_fetched_msg -

  core/deltachat-rpc-client/tests/test_something.py

  Line 623 in 0d46626

  def test_reaction_to_partially_fetched_msg(acfactory, tmp_path):

• test_partial_download_and_ephemeral -

  core/src/download.rs

  Line 391 in 8b4c718

  async fn test_partial_download_and_ephemeral() -> Result<()> {

• test_status_update_expands_to_nothing -

  core/src/download.rs

  Line 425 in 8b4c718

  async fn test_status_update_expands_to_nothing() -> Result<()> {

• test_partial_download_trashed -

  core/src/download.rs

  Line 536 in 8b4c718

  async fn test_partial_download_trashed() -> Result<()> {

• test_partial_download_and_reaction -

  core/src/reaction.rs

  Line 929 in 8b4c718

  async fn test_partial_download_and_reaction() -> Result<()> {

• test_partial_group_consistency -

  core/src/receive_imf/receive_imf_tests.rs

  Line 4473 in 8b4c718

  async fn test_partial_group_consistency() -> Result<()> {

• test_partial_download_key_contact_lookup -

  core/src/receive_imf/receive_imf_tests.rs

  Line 5288 in 8b4c718

  async fn test_partial_download_key_contact_lookup() -> Result<()> {

• ⭐test_webxdc_update_for_not_downloaded_instance -

  core/src/webxdc/webxdc_tests.rs

  Line 333 in 8b4c718

  async fn test_webxdc_update_for_not_downloaded_instance() -> Result<()> {

• test_no_partial_calls -

  core/src/calls/calls_tests.rs

  Line 617 in 8b4c718

  async fn test_no_partial_calls() -> Result<()> {

• test_markseen_not_downloaded_msg -

  core/src/message/message_tests.rs

  Line 331 in 8b4c718

  async fn test_markseen_not_downloaded_msg() -> Result<()> {

• test_msg_seen_on_imap_when_downloaded -

  core/src/message/message_tests.rs

  Line 404 in 8b4c718

  async fn test_msg_seen_on_imap_when_downloaded() -> Result<()> {

• test_create_group_with_big_msg -

  core/src/receive_imf/receive_imf_tests.rs

  Line 4398 in 8b4c718

  async fn test_create_group_with_big_msg() -> Result<()> {

• test_download_later -

  core/src/receive_imf/receive_imf_tests.rs

  Line 4333 in 8b4c718

  async fn test_download_later() -> Result<()> {

• test_prefer_references_to_downloaded_msgs -

  core/src/receive_imf/receive_imf_tests.rs

  Line 4792 in 8b4c718

  async fn test_prefer_references_to_downloaded_msgs() -> Result<()> {

• test_download_on_demand -

  core/deltachat-rpc-client/tests/test_chatlist_events.py

  Line 114 in 56370c2

  def test_download_on_demand(acfactory: ACFactory) -> None:

• test_download_limit_chat_assignment -

  core/deltachat-rpc-client/tests/test_something.py

  Line 723 in 56370c2

  def test_download_limit_chat_assignment(acfactory, tmp_path, n_accounts):

• test_webxdc_download_on_demand -

  core/python/tests/test_1_online.py

  Line 225 in 9bc2aee

  def test_webxdc_download_on_demand(acfactory, data, lp):

part of #7367

[Simon-Laux]

• run and fix python tests
  • jsonrpc
  • cffi
• solve that it stops receiving messages (when used in desktop)

[Simon-Laux]

todo comment

[Simon-Laux]

Note that there may be existing message-stubs that are not downloaded yet. After updating, the "Download" button will probably become non-functional; this is fine. We should make sure that DC doesn't crash when clicking "Download".

currently I'm still asking myself whether we have to to make this sacrifice or if we can still have a last version that has an option to download old message stubs and remove it in the version after...

As of the time of writing the download logic still works, because I have only removed the partial download logic that creates the stubs so far.

my current feeling/idea is to remove it in a dedicated pr as soon as it makes problems / the implementation of the new method harder - that way this pr would also be focused on the removal of just the stub creation part of partial download.

[Hocuri]

It's not that big of a sacrifice:

• download-on-demand is just an option (i.e. many people don't have it activated, since they don't change the settings)
• this option never worked really well
• It can already happen that you can't fully download a message, because it has been deleted on the server already.
• The user sees that there is a failure, and can ask the sender to send the message again

It does make sense to remove only the partial-download logic in the PR here, and then remove the replace_msg_id logic in a later PR. But if there is any kind of effort in it, it's not worth it, esp. as we need pre-messages rather sooner than later for calls etc.

[Hocuri]

Nice! LGTM once all comments are addressed (i.e. either resolved them, or commented why it's not worth it / doesn't make sense)

BTW, in general, it's good to request a review from some people using the Github UI once you've finished your PR, in order to get speedier reviews

[Hocuri]

It's not that big of a sacrifice:

• download-on-demand is just an option (i.e. many people don't have it activated, since they don't change the settings)
• this option never worked really well
• It can already happen that you can't fully download a message, because it has been deleted on the server already.
• The user sees that there is a failure, and can ask the sender to send the message again

It does make sense to remove only the partial-download logic in the PR here, and then remove the replace_msg_id logic in a later PR. But if there is any kind of effort in it, it's not worth it, esp. as we need pre-messages rather sooner than later for calls etc.

[Simon-Laux]

I don't see how this error is related to the changes in this pr. I'll merge it into the pre-message feature branch anyway now.

error: unresolved link to `Context::set_stock-translation`
   --> src/context.rs:141:11
    |
141 |     /// [`Context::set_stock-translation`] or [`Accounts::set_stock_translation`] calls.
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the struct `Context` has no field or associated item named `set_stock-translation`
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

[Hocuri]

I don't see how this error is related to the changes in this pr.

It was fixed by 75eb94e, rebasing on main or merging main will fix the problem