Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cca4174
remove: partial downloads
Simon-Laux Oct 30, 2025
fdcb222
remove partial download tests and fix issues in other tests
Simon-Laux Oct 30, 2025
7f3eabc
remove remaining partial messages tests
Simon-Laux Oct 30, 2025
2e2bc12
remove download limit validation, it does not really matter in the new
Simon-Laux Oct 30, 2025
902a0d7
fix clippy
Simon-Laux Oct 30, 2025
70d7e04
ignore that `partial_download_msg_body` is dead code
Simon-Laux Oct 30, 2025
2284d36
remove test for download limit validation
Simon-Laux Oct 30, 2025
53163ab
remove `test_download_on_demand`
Simon-Laux Oct 31, 2025
cc9fe5d
remove test `test_download_limit_chat_assignment`
Simon-Laux Oct 31, 2025
d1dc322
Remove superfluous parentheses.
Simon-Laux Oct 31, 2025
58ad664
fix the issue that broke the imap fetching
Simon-Laux Oct 31, 2025
014d80b
fix python lint errors
Simon-Laux Oct 31, 2025
a044436
remove cffi python test`test_webxdc_download_on_demand`
Simon-Laux Nov 1, 2025
28cca8b
fix python lint
Simon-Laux Nov 1, 2025
560e86b
fix rebase issue
Simon-Laux Nov 6, 2025
5a2ca7a
fix another rebase issue
Simon-Laux Nov 6, 2025
10c2016
fix lint of python test
Simon-Laux Nov 6, 2025
37b027a
reintroduce `Config::FailOnReceivingFullMsg` but renamed it to
Simon-Laux Nov 6, 2025
afa46c8
allow exclusion of `simulate_receive_imf_error` from get_info
Simon-Laux Nov 8, 2025
6d11e08
adapt comment
Simon-Laux Nov 12, 2025
05a1967
remove `StockMessage::PartialDownloadMsgBody`
Simon-Laux Nov 12, 2025
b70a41f
fix clippy issue
Simon-Laux Nov 14, 2025
971286b
restore test `test_downloadstate_values`
Simon-Laux Nov 14, 2025
af00375
restore test `test_webxdc_update_for_not_downloaded_instance` and rename
Simon-Laux Nov 14, 2025
ab1fdfa
bring back receiving half of `test_partial_receive_imf` and rename to
Simon-Laux Nov 14, 2025
f7d8812
remove `test_webxdc_update_for_not_yet_received_instance`
Simon-Laux Nov 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove StockMessage::PartialDownloadMsgBody
  • Loading branch information
Simon-Laux committed Nov 12, 2025
commit 05a1967678a65cea57e2a549ddd52eada750170f
8 changes: 1 addition & 7 deletions deltachat-ffi/deltachat.h
Original file line number Diff line number Diff line change
Expand Up @@ -7241,13 +7241,7 @@ void dc_event_unref(dc_event_t* event);
/// `%1$s` will be replaced by the percentage used
#define DC_STR_QUOTA_EXCEEDING_MSG_BODY 98

/// "%1$s message"
///
/// Used as the message body when a message
/// was not yet downloaded completely
/// (dc_msg_get_download_state() is e.g. @ref DC_DOWNLOAD_AVAILABLE).
///
/// `%1$s` will be replaced by human-readable size (e.g. "1.2 MiB").
/// @deprecated Deprecated 2025-11-12, this string is no longer needed.
#define DC_STR_PARTIAL_DOWNLOAD_MSG_BODY 99

/// "Multi Device Synchronization"
Expand Down
9 changes: 0 additions & 9 deletions src/stock_str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1182,15 +1182,6 @@ pub(crate) async fn quota_exceeding(context: &Context, highest_usage: u64) -> St
.replace("%%", "%")
}

/// Stock string: `%1$s message` with placeholder replaced by human-readable size.
#[allow(dead_code)]
pub(crate) async fn partial_download_msg_body(context: &Context, org_bytes: u32) -> String {
let size = &format_size(org_bytes, BINARY);
translated(context, StockMessage::PartialDownloadMsgBody)
.await
.replace1(size)
}

/// Stock string: `Incoming Messages`.
pub(crate) async fn incoming_messages(context: &Context) -> String {
translated(context, StockMessage::IncomingMessages).await
Expand Down
8 changes: 0 additions & 8 deletions src/stock_str/stock_str_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,6 @@ async fn test_quota_exceeding_stock_str() -> Result<()> {
Ok(())
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn test_partial_download_msg_body() -> Result<()> {
let t = TestContext::new().await;
let str = partial_download_msg_body(&t, 1024 * 1024).await;
assert_eq!(str, "1 MiB message");
Ok(())
}

#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn test_update_device_chats() {
let t = TestContext::new_alice().await;
Expand Down
Loading