-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Added a new Author #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abhik1998
wants to merge
1
commit into
chromium:master
Choose a base branch
from
Abhik1998:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ls60629
pushed a commit
to ls60629/chromium
that referenced
this pull request
Apr 11, 2021
…ithout flag The function assumes that flag CSSAtRuleCounterStyle is on. When incidentally called without the flag, it always returns false, and causes layout invalidation on list markers. Hence, this patch makes the function called only when the flag is on. (cherry picked from commit 721da1f) Bug: 1182969 Change-Id: I4c1db30c2efaf427b0629755b24a072d22f9bc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2724882 Reviewed-by: Anders Hartvoll Ruud <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Xiaocheng Hu <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#858699} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729696 Auto-Submit: Xiaocheng Hu <[email protected]> Commit-Queue: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/branch-heads/4430@{chromium#80} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Apr 13, 2021
This cl fixes the missing next button in the gaia login page of the EduCoexistence flow. (cherry picked from commit 225541f) Bug: 1166901 Change-Id: Iae8d397079d939257fb65553ee3c9bb67d07ae19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631225 Reviewed-by: Xiyuan Xia <[email protected]> Reviewed-by: Dan S <[email protected]> Commit-Queue: Yilkal Abe <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#844244} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641116 Reviewed-by: Yilkal Abe <[email protected]> Cr-Commit-Position: refs/branch-heads/4389@{chromium#80} Cr-Branched-From: 9251c5d-refs/heads/master@{#843830}
blattersturm
pushed a commit
to citizenfx/chromium
that referenced
this pull request
Apr 29, 2021
Add 'Activating...' label and spinner to network-list-item if it contains a pSIM network that has an activation state of kActivating. Screenshot: https://screenshot.googleplex.com/996u8J4LzYuDwb5.png (cherry picked from commit b880253) Bug: 1196507 Change-Id: Id0ff897cd192747588cfdd43577bce774d0c3950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2818729 Commit-Queue: Gordon Seto <[email protected]> Reviewed-by: Kyle Horimoto <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#871209} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826568 Commit-Queue: Kyle Horimoto <[email protected]> Auto-Submit: Kyle Horimoto <[email protected]> Reviewed-by: Gordon Seto <[email protected]> Cr-Commit-Position: refs/branch-heads/4472@{chromium#80} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
jchen10
pushed a commit
to jchen10/chromium
that referenced
this pull request
Jul 15, 2021
[email protected] Change-Id: I0a7a4ef9a0ce4eecb5dfb9bcbf0bad4f246faf7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144443 Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4103@{chromium#80} Cr-Branched-From: 8ad47e8-refs/heads/master@{#756066}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Jul 23, 2021
When a machine requires to pass the attach APN to the LTE modem, we should honor the setting also in guest mode and keep the feature flag rather than filtering it out. (cherry picked from commit ab54819) Bug: b/170273532 Change-Id: I92f6ba584ae4f351b6fbb85c160b1c75c7f6663e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2916954 Reviewed-by: Xiyuan Xia <[email protected]> Commit-Queue: Vincent Palatin <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#886413} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917295 Auto-Submit: Vincent Palatin <[email protected]> Commit-Queue: Xiyuan Xia <[email protected]> Cr-Commit-Position: refs/branch-heads/4515@{chromium#80} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Sep 4, 2021
Full restore stores PWAs in FullRestoreSaveHandler under the app id of chrome browser. SWAs are stored under their own app id. Before this patch, there would be a crash because PWAs could not get app launch info from FullRestoreSaveHandler. This CL fixes that by having PWAs get the app launch info of the chrome browser. (cherry picked from commit 22c3902) Test: manual Fixed: 1230097 Change-Id: I9b71e39d68d6ce2abcc5f0b7d5ff6d7e49a6580e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3039879 Reviewed-by: Xiaoqian Dai <[email protected]> Reviewed-by: Xiyuan Xia <[email protected]> Commit-Queue: Sammie Quon <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#903275} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3046521 Cr-Commit-Position: refs/branch-heads/4577@{chromium#80} Cr-Branched-From: 761ddde-refs/heads/master@{#902210}
nift4
pushed a commit
to nift4/chromium
that referenced
this pull request
Sep 22, 2021
PaintCanvasVideoRenderer, for complicated reasons, maintains a cached texture resulting from an YUV to RGB conversion. The goal of the cache is not to avoid repeated YUV to RGB conversions, but to avoid repeated allocation and freeing of the RGB texture every frame. WebMediaPlayerMSCompositor::CheckForFrameChanges resets this cache every time it gets a new frame, which makes the cache in PaintCanvasVideoRenderer useless. Change WebMediaPlayerMSCompositor::CheckForFrameChanges to only reset the cache when the frame size changes. (cherry picked from commit 3c8a7d5) Bug: 1235686 Change-Id: If8a6746fdc6828b9852653631d0de72777877b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3089355 Reviewed-by: Guido Urdaneta <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Commit-Queue: ccameron <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#911727} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101105 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Kenneth Russell <[email protected]> Commit-Queue: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/branch-heads/4606@{chromium#80} Cr-Branched-From: 35b0d5a-refs/heads/master@{#911515}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Oct 21, 2021
This will allow bot account to land automatic updates to log_list.json Sample CL: crrev.com/c/3148059 (cherry picked from commit ac11a42) Change-Id: I0c450c44cbd45552b33f3946d92aa0d298c34156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149352 Commit-Queue: Carlos IL <[email protected]> Auto-Submit: Carlos IL <[email protected]> Reviewed-by: Ryan Sleevi <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#920259} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163448 Commit-Queue: Ryan Sleevi <[email protected]> Cr-Commit-Position: refs/branch-heads/4638@{chromium#80} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
NikitaNikolaenko
pushed a commit
to Decentr-net/chromium
that referenced
this pull request
Nov 11, 2021
The following heuristics are made Finch configurable: - Generic add-to-cart pattern - Per-domain and generic cart URL pattern - Generic checkout URL pattern - Generic purchase button text pattern (cherry picked from commit 0596806) Bug: 1258278 Change-Id: Id118258c174568bf254acc2490f33dd5834776a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3211594 Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]> Auto-Submit: Wei-Yin Chen (陳威尹) <[email protected]> Reviewed-by: Yue Zhang <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#930255} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3219389 Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/4664@{chromium#80} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
davidwongiiss1984
pushed a commit
to omsproject/chromium
that referenced
this pull request
Dec 14, 2021
Change-Id: I2fc22893b1eb760a0b99ec85ca8a5832f4c542bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3273554 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4692@{chromium#80} Cr-Branched-From: 038cd96-refs/heads/main@{#938553}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Feb 3, 2022
Clamps scroll position in remote mode, in order to match the behavior of scrollTo() in local mode. This calculation needs to account for the presence or absence of scroll bars, as well as directionality. As a backstop, synchronizes the scroll position from the final "ackScrollToRemote" message. This recovers from races that may change the acceptable scroll positions on the remote side, such as resizes. Updates a few of the existing PDFExtensionJSTest.Viewport tests to correctly set document dimensions larger than the viewport before trying to scroll. (Note that the first call to setDocumentDimensions() tries to fit by width.) Also removes redundant coverage of the "syncScrollToRemote" message in the various testSetPosition_remote_* tests, and makes sure pending "syncScrollToRemote" messages are acknowledged before trying to exercise ackScrollToRemote(). (cherry picked from commit 2ff3201) Bug: 1271262 Change-Id: Iac5de290b3c0dc217047373c87370475b2e32941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340083 Reviewed-by: Daniel Hosseinian <[email protected]> Commit-Queue: K. Moon <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#951820} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341293 Reviewed-by: Lei Zhang <[email protected]> Auto-Submit: K. Moon <[email protected]> Cr-Commit-Position: refs/branch-heads/4758@{#80} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
Windows only. I suspect that the Local-State-pref-based approach is capturing fewer extension renderer crashes than Stability.Counts2 because the updated crash count is not being persisted. If this is indeed the case, I expect we'd be able to see it in beta data. I intend to try to merge this to M99. (cherry picked from commit 8680040) Bug: 1291000, b/215752742 Change-Id: I55e57975a6f1285bc6e972646ab85b7f9dcd4fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3414956 Commit-Queue: Caitlin Fischer <[email protected]> Auto-Submit: Caitlin Fischer <[email protected]> Reviewed-by: Robert Kaplow <[email protected]> Commit-Queue: Robert Kaplow <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#963548} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419260 Cr-Commit-Position: refs/branch-heads/4844@{chromium#80} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Apr 19, 2022
This should fix a rare race which causes CHECKs because UI strings and language string are not the same. See bug for details. (cherry picked from commit 9d8e89f) Bug: 1289095 Change-Id: Ib79a3fdf15dd56cd9f36550c8f4dea69c147bb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473375 Auto-Submit: Roman Sorokin <[email protected]> Reviewed-by: Denis Kuznetsov <[email protected]> Commit-Queue: Denis Kuznetsov <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#973573} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3486897 Cr-Commit-Position: refs/branch-heads/4896@{chromium#80} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
fujunwei
referenced
this pull request
in otcshare/chromium-src
May 4, 2022
Change-Id: Ibb7b5f3ce935d3c36a54c21f220eb5024c9244cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599979 Auto-Submit: Ben Mason <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5005@{#80} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
Change-Id: Iee16c79b66e502d6c84477b88e55a2dbf69e81a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546076 Auto-Submit: Ben Mason <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/4951@{chromium#80} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
…17 commits) Contains an improvement in checking CFF glyph name length, potentially related to issue 1316699. [1] [1] harfbuzz/harfbuzz@a2f132f https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/6454cec085ba..acdab17ed350 $ git log 6454cec08..acdab17ed --date=short --no-merges --format='%ad %ae %s' 2022-05-13 behdad [cff] Cosmetic in parsed_values_t 2022-05-13 behdad [cff] Check buf_len, not buf 2022-05-13 grieger [subset] fix potential integer overflow in gname_t::cmp. 2022-05-13 behdad [cff-common] In INDEX, return empty bytes if length is zero 2022-05-13 behdad [cff] Check glyph-name's length, not arrayZ 2022-05-13 jeremiazhao fix build requirements for fedora/centos in buiding document 2022-05-10 thomas.devoogdt [meta] fix type traits on gcc 4.9 #3526 2022-05-13 grieger [perf] fix typo in perf Makefile. 2022-05-12 behdad [vector] Add tests for move constructor/assignment 2022-05-12 behdad [map] Fix map copy/move constructors to actually work 2022-05-12 behdad [set] Fix set copy/move constructors to actually work 2022-05-12 behdad [vector] Remove explicit std::move 2022-05-12 behdad [set] Tweak move operators a bit 2022-05-11 behdad [gsubgpos] Clean up OT::ClassDefFormat2::intersected_class_glyphs 0 case 2022-05-11 behdad [gsubgpos] Simplify OT::ClassDefFormat2::intersected_class_glyphs() 2022-05-11 behdad [subset] Optimize ClassDef1::intersected_class_glyphs() for class0 2022-05-11 behdad [subset] Allocate same size as source table for GSUB/GPOS/name 2022-05-11 behdad [subset] Use vector.allocated size instead of tracking buf_size 2022-05-11 behdad [cff-subset] Pre-alloc vector for operator decoding 2022-05-10 behdad [perf/benchmark-subset] Minor cleanup 2022-05-10 behdad [subset] Retain buffer across table subset operations 2022-05-10 behdad [cff] Convert interpretation environment to use constructor 2022-05-10 behdad [cff] Convert subr_subset_param_t to use constructor 2022-05-10 behdad [cff] Convert cff2_extents_param_t to use constructor 2022-05-10 behdad [cff] Convert cff1_extents_param_t to use constructor 2022-05-10 behdad [cff] Convert get_seac_param_t to use constructor 2022-05-10 behdad [cff] Use hb_ubytes_t() instead of Null(hb_ubytes_t) 2022-05-10 behdad [cff-common] Optimize INDEX::operator[] 2022-05-10 behdad Revert "[cff-common] Optimize INDEX::operator[]" 2022-05-10 behdad Revert "[cff] Add an unlikely()" 2022-05-10 behdad [cff] Add an unlikely() 2022-05-10 behdad [cff-common] Optimize INDEX::operator[] 2022-05-10 grieger [perf] Make subset benchmark data driven. 2022-05-10 behdad [cff2] Change extents/shape stack to be just a number 2022-05-10 grieger [perf] Add benchmarks for CFF subsetting. 2022-05-10 grieger [subset] Enforce cmap12 group ordering constraints in collect_mapping. 2022-05-09 behdad [cff] Fix arg-stack peek() impl 2022-05-09 behdad [cff] Tighten up arg-stack access 2022-05-09 behdad [cff] Allocate stack inline instead of using hb_vector_t 2022-05-09 behdad [cff] Use using instead of typedef 2022-05-09 behdad [cff-common] Use existing types for str_buff_vec_t 2022-05-09 behdad [cff-common] Remove unused method 2022-05-09 behdad [cff] Replace byte_str_t with hb_bytes_t use 2022-05-09 behdad [cff] Remove custom byte_str_t impl 2022-05-09 behdad [cff-common] Indent 2022-05-09 behdad [cff-common] Remove unused INDEX::serialize() method 2022-05-09 behdad [cff-common] Write str_buf_t::total_size() as dagger 2022-05-09 behdad [cff-common] Use range-based loop in str_buff_vec_t 2022-05-09 behdad [cff-common] Write INDEX offset-size calc using hb_bit_storage() 2022-05-09 behdad [cff-common] Add assert to INDEX::set_offset_at() (...) 2022-05-05 behdad [cmap] Use -1 as Unicode sentinel, not U+FFFF in Format12 serialize 2022-05-05 behdad [cmap] Use iterator bool operator 2022-05-05 behdad [subset] Compute set max using previous() 2022-05-05 behdad [subset] Don't go into glyf table if it's empty 2022-05-05 behdad [subset] Use del_range in _remove_invalid_gids 2022-05-04 behdad [subset] Cosmetic; use set bulk array population instead of for loop 2022-05-04 grieger [perf] use option_t in subset benchmark to select between glyphs and codepoint subset. 2022-05-04 behdad [subset] Remove outdated comment 2022-05-04 grieger [perf] benchmark subsetting via glyphs. 2022-05-04 behdad [subset] In cmap planning, remove a qsort() 2022-05-04 grieger [subset] Re-introduce size threshold in choosing unicode collection method. 2022-05-04 grieger [subset] Presize unicode to gid list to unicodes + glyphs size. 2022-05-03 grieger [subset] Remove switch to alternate unicode collection at large subset sizes. 2022-05-03 grieger [subset] Embed unicode to gid list vector in subset plan. 2022-05-02 behdad [perf/benchmark-font] Add benchmark for glyph_h_advance 2022-05-02 behdad [perf/benchmark-font] Add a couple Noto fonts 2022-05-02 behdad Add fast-path for big-endian 32-bit byteswap 2022-05-02 behdad [perf/benchmark-font] Cosmetic 2022-05-02 behdad [cmap] Sprinkle some 'unlikely's 2022-05-02 grieger [subset] In _populate_unicodes_to_retain populate unicodes in order. 2022-05-02 behdad [perf/benchmark-font] Actually make nominal_glyph bench work 2022-05-02 behdad [perf/benchmark-font] Add back testing of is_variable 2022-05-02 behdad [perf/benchmark-font] Fix build without freetype 2022-05-02 behdad [perf/benchmark-font] Benchmark get_nominal_glyph 2022-05-02 grieger [subset] cache cp to new gid list in subset plan. 2022-05-02 behdad [perf/benchmark-font] Parametrize test 2022-05-02 behdad [perf/perf] Rename to benchmark-font 2022-05-02 behdad [perf/perf] Move all logic to perf-draw, for now 2022-05-02 behdad [perf/perf] Remove ttf-parser backend 2022-05-02 behdad [perf/perf] Rely on hb-draw to measure ft performance 2022-04-29 grieger [subset] Change serialize_rangeoffset_glyid back to using iterator. 2022-04-29 grieger [subset] in cmap4 serialization save cp to gid iter to memory. 2022-04-29 grieger [subset] In cmap4 serialization reduce unnessecary calls into the iterator. 2022-04-29 grieger [subset] In unicodes cache cleanup if set insert fails. 2022-04-29 behdad Try to fix distcheck 2022-04-29 grieger [subset] s/void */intptr_t. 2022-04-29 grieger [subset] cache results of collect_unicodes. 2022-04-29 behdad [benchmark-shape] Break lines and shape separately 2022-04-29 behdad [benchmark-shape] Data-driven test sets 2022-04-29 behdad [perf] Spawn off benchmark-shape from perf runner 2022-04-29 behdad [benchmark-set] Split SetLookup into an ordered and random version 2022-04-29 behdad [benchmark-set] At least increase needle by one in lookup benchmark 2022-04-29 behdad [benchmark-set] At least increase needle by one in lookup benchmark 2022-04-29 grieger [subset] Optimize Cmap4 collect_unicodes. 2022-04-29 behdad [benchmark-map] Remove rand() overhead from benchmark 2022-04-29 behdad [set] Optimize const page_for() using last_page_lookup caching 2022-04-29 behdad [set] Optimize non-const page_for() using last_page_lookup caching 2022-04-29 behdad [benchmark-set] Reduce lookup benchmark overhead 2022-04-28 behdad [test] Add test 2022-04-27 behdad [CFF] Fix parsing of empty Index Created with: roll-dep src/third_party/harfbuzz-ng/src R=[email protected],[email protected],[email protected],[email protected],[email protected] (cherry picked from commit f8a60b4) Bug: 1316699 Change-Id: Ie0d4ef21ba667a10d60669ee0e3792f0fe4c870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650436 Auto-Submit: Dominik Röttsches <[email protected]> Commit-Queue: Koji Ishii <[email protected]> Commit-Queue: Dominik Röttsches <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1003657} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652048 Commit-Queue: Krishna Govind <[email protected]> Reviewed-by: Krishna Govind <[email protected]> Owners-Override: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/5060@{chromium#80} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
This method is called also when the scale factor MAY change and may not results in the actual size change. In that case, we should not call the observer which may close auto fill window. This CL intentionally still try to update the compositor to minimize the risk of merging back to m104. Bug: 1329481 Test: covered by unittest. (cherry picked from commit 6038cd3) Change-Id: I851e59b6178e46e1d4a4e7117c340f38190cc6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704961 Reviewed-by: Scott Violet <[email protected]> Commit-Queue: Mitsuru Oshima <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1014083} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3707553 Commit-Queue: Scott Violet <[email protected]> Auto-Submit: Mitsuru Oshima <[email protected]> Cr-Commit-Position: refs/branch-heads/5112@{chromium#80} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
…dInPixels" This reverts commit 965f7ea. Reason for revert: causing regression crbug.com/1336548 Original change's description: > [m104] Only notify when size acutally changed in OnHostResizedInPixels > > This method is called also when the scale factor MAY change and may not > results in the actual size change. In that case, we should not call > the observer which may close auto fill window. > > This CL intentionally still try to update the compositor to minimize the > risk of merging back to m104. > > Bug: 1329481 > Test: covered by unittest. > > (cherry picked from commit 6038cd3) > > Change-Id: I851e59b6178e46e1d4a4e7117c340f38190cc6ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704961 > Reviewed-by: Scott Violet <[email protected]> > Commit-Queue: Mitsuru Oshima <[email protected]> > Cr-Original-Commit-Position: refs/heads/main@{#1014083} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3707553 > Commit-Queue: Scott Violet <[email protected]> > Auto-Submit: Mitsuru Oshima <[email protected]> > Cr-Commit-Position: refs/branch-heads/5112@{chromium#80} > Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729} Bug: 1329481 Change-Id: I75c5844a08b87e3cf071637a9e80cb48b26bef1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3712180 Reviewed-by: Scott Violet <[email protected]> Commit-Queue: Mitsuru Oshima <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5112@{chromium#126} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
beasonxu
pushed a commit
to ipxbro/chromium
that referenced
this pull request
Sep 3, 2022
(cherry picked from commit f894c02) Fixed: 1347186 Change-Id: Ia1c3cf0f2cf8ad5a3d98d4ca5c09edccc5e26d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785075 Reviewed-by: Victor Vianna <[email protected]> Reviewed-by: Jeffrey Cohen <[email protected]> Commit-Queue: Sky Malice <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1028465} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3790280 Cr-Commit-Position: refs/branch-heads/5195@{chromium#80} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
(cherry picked from commit c1d08c2) Bug: 1382140 Change-Id: I56f2668bbed8d99729ebe68f845d8b60dd186fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4026683 Reviewed-by: Sergio Collazos <[email protected]> Commit-Queue: Adam Arcaro <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1071272} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030927 Auto-Submit: Adam Arcaro <[email protected]> Commit-Queue: Sergio Collazos <[email protected]> Cr-Commit-Position: refs/branch-heads/5414@{chromium#80} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
BUG=1403291 (cherry picked from commit 52e3bd9) Change-Id: I4dcfab87907b38c43f5152292e3d66296f910aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4122979 Commit-Queue: Martin Kreichgauer <[email protected]> Auto-Submit: Adam Langley <[email protected]> Reviewed-by: Martin Kreichgauer <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1087059} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127289 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5481@{chromium#80} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 903a579) Bug: 1411224 Change-Id: Iea2d3d70b2d657bb2561cdeb1b82ab2663decb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200655 Auto-Submit: Olesia Marukhno <[email protected]> Reviewed-by: Theodore Olsauskas-Warren <[email protected]> Commit-Queue: Theodore Olsauskas-Warren <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1099186} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4212289 Commit-Queue: Olesia Marukhno <[email protected]> Cr-Commit-Position: refs/branch-heads/5563@{chromium#80} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
aarongable
pushed a commit
that referenced
this pull request
Mar 10, 2023
…1 commit) https://chromium.googlesource.com/external/github.com/chromium/content_analysis_sdk.git/+log/5e3ee30867df..01c34145717c $ git log 5e3ee3086..01c341457 --date=short --no-merges --format='%ad %ae %s' 2023-03-10 roger Make agent path best effort (#80) Created with: roll-dep src/third_party/content_analysis_sdk/src Bug: b:272749545 Change-Id: I15ed6f6bedd352f49fdae71d39475f653462a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329543 Reviewed-by: Dominique Fauteux-Chapleau <[email protected]> Commit-Queue: Roger Tawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115826}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
The histograms record the total number of off-store extensions on a client and the duration of the data collection process. (cherry picked from commit 2c37b98) Bug: 1384755 Change-Id: I35ae77e8749070db3128e031cf1b25da848d5e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288492 Commit-Queue: Richard Chen <[email protected]> Reviewed-by: thefrog <[email protected]> Reviewed-by: Anunoy Ghosh <[email protected]> Reviewed-by: Zack Han <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1110533} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4298173 Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5615@{chromium#80} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
…0-benchmark-114.0.5735.10-r1 to 114-5707.0-1682337030-benchmark-114.0.5735.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-exp-chromium-beta Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ia69e9c2e806ef199d479fe3f05cc89f84029930f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4495177 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5735@{chromium#80} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 27, 2023
Record UseCounter when InstallEvent.registerRouter is called. This is a requirement to run Origin Trial. UseCounter or UMAs for the router evaluation phase will be added in the next CL. (cherry picked from commit cfe14b4) Bug: 1371756 Change-Id: I525edcea06ca9789345a3e78740007c688ff803b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4630653 Reviewed-by: Yoshisato Yanagisawa <[email protected]> Commit-Queue: Shunya Shishido <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1160511} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4645318 Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/branch-heads/5845@{chromium#80} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
The shader source has changed, necessitating an update. (cherry picked from commit 16d0026) Bug: 1423136, 1448879 Change-Id: I3b7c7057a34952fcbd031f9c03066b43c667ef92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4563655 Commit-Queue: Geoff Lang <[email protected]> Reviewed-by: Geoff Lang <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1149072} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571344 Commit-Queue: Scott Violet <[email protected]> Reviewed-by: Clark DuVall <[email protected]> Commit-Queue: Clark DuVall <[email protected]> Cr-Commit-Position: refs/branch-heads/5790@{chromium#80} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
…ark-118.0.5993.5-r1 to 118-5938.29-1693820316-benchmark-118.0.5993.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I6ab4a30a90dec85e2c3c16b83523855bb7e70ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853007 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/5993@{chromium#80} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
…bsolete `kSkipCookieDeprecationLabelForStoragePartitions` feature. For pre-periods, instead of skipping the label entirely, we might want to include all the pre-period groups under a different "preperiod" label, or something more granular. (cherry picked from commit 8bb6982) Bug: 1488961 Change-Id: I5916ea924a7fa4ad74ec68de51dbd5f5277e1c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4909796 Commit-Queue: Anton Maliev <[email protected]> Reviewed-by: Nan Lin <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1204987} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4915553 Auto-Submit: Anton Maliev <[email protected]> Commit-Queue: Nan Lin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/6045@{chromium#80} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
aarongable
pushed a commit
that referenced
this pull request
Jan 25, 2024
Roll Chrome Mac PGO profile from chrome-mac-6261-1706155249-e491a6ee7239571f0e61bfcf05ab24bbcdd41a03.profdata to chrome-mac-6261-1706179408-c096db77cd8d935f4c594e644c9b478b68896a4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m122.try:mac-chrome Tbr: [email protected] Change-Id: Ief456a65fc911bfd556a100707924360b179d12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5236867 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6261@{#80} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
aarongable
pushed a commit
that referenced
this pull request
Feb 23, 2024
This reverts commit 584e032. Reason for revert: breaks MTK b/326134132 Breaks MTK because MTK has GAMMA_LUT broken. Historically we haven't been using this path, and so it may be broken on other devices. We're going to have to explicitly allow-list GAMMA_LUT and DEGAMMA_LUT, and assume they are broken on all devices (except for Chromecast). Original change's description: > Drm: Always specify GAMMA_LUT > > The last time something like this was tried, we set both DEGAMMA_LUT > and GAMMA_LUT. The DEGAMMA_LUT parameter is unreliable to the point > of being unusable. Closer examination of all paths that use it reveals > that they are all disabled. > > This is not obviously the case for GAMMA_LUT, which is used by other > paths. > > The GAMMA_LUT will need to be changed to implement night light and > ambient adjustment on platforms that have a functional DEGAMMA_LUT > (platforms where the CTM is applied in linear space) and on > platforms that don't have a CTM. > > Bug: 1505062 > Change-Id: I52d02b2ce624d0bb3c3f79e6ef36cd10e46a06e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5277072 > Reviewed-by: Sasha McIntosh <[email protected]> > Commit-Queue: ccameron chromium <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1258708} Bug: 1505062 Bug: b:326134132, b:321593582, b:326000262 (cherry picked from commit dc981b2) Change-Id: I0b9a45257da445ea5cd8a1b6dcc6ce60b8fcbb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310859 Commit-Queue: ccameron chromium <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1263078} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315480 Commit-Queue: Peter McNeeley <[email protected]> Reviewed-by: ccameron chromium <[email protected]> Reviewed-by: Peter McNeeley <[email protected]> Cr-Commit-Position: refs/branch-heads/6312@{#80} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
aarongable
pushed a commit
that referenced
this pull request
Mar 21, 2024
We want the XDTR favicon to match the Drive favicon size. Screenshot: http://screenshot/BMB5qppYLqPmHMa (cherry picked from commit bccda56) Bug: 329869339 Change-Id: I317231757392e561a60199b13c14e0b1ef841f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5380561 Commit-Queue: Marlon Facey <[email protected]> Reviewed-by: Roman Arora <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1275212} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5381152 Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/6367@{#80} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
The redirect was broken by CL: https://crrev.com/c/4732981 This bug crept in because of two issues: 1) `ShowDiceSigninTab()` had a default value for the redirect parameter, and would do no redirection by default. This default behavior made it hard to update all callers in the previous CL and one of them was missed. 2) The integration test was using the deprecated `ShowSignin()` function instead of `ShowDiceEnableSyncTab()`, and as a result the broken function was not tested. This CL addresses the two issues: - removing the default empty redirect, to make sure all callers pass the right value explicitly. - the test is switched away from the deprecated function and tests the recommended function instead. The deprecated function is losing some coverage, but it still has some, and there is only one caller of that function anyway. The deprecated function will be removed as a follow up. The CL also improves comments for the redirect behavior. (cherry picked from commit 85e079b) Fixed: 1472219 Change-Id: I468483145beaebe54d43bf38527da9bbd2947b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4773361 Commit-Queue: David Roger <[email protected]> Reviewed-by: Nicolas Dossou-Gbété <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1182575} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774723 Auto-Submit: David Roger <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/5938@{chromium#80} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
jiongle1
pushed a commit
to jiongle1/chromium
that referenced
this pull request
Mar 27, 2024
[email protected] Change-Id: Id01e49ea5aab90ef3b5e4037b8f953a4dea1fc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545077 Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4324@{chromium#80} Cr-Branched-From: c73b5a6-refs/heads/master@{#827102}
jiongle1
pushed a commit
to jiongle1/chromium
that referenced
this pull request
Mar 27, 2024
… check (cherry picked from commit d267b96) Bug: 1120824, 1070620 Change-Id: I6e9ab2cb92801f03afb5bcaba0415d7d8c35636f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372302 Commit-Queue: Andrey Zaytsev <[email protected]> Commit-Queue: Martin Šrámek <[email protected]> Auto-Submit: Andrey Zaytsev <[email protected]> Reviewed-by: Martin Šrámek <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#800969} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376531 Reviewed-by: Krishna Govind <[email protected]> Commit-Queue: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/4240@{chromium#80} Cr-Branched-From: f297677-refs/heads/master@{#800218}
jiongle1
pushed a commit
to jiongle1/chromium
that referenced
this pull request
Mar 27, 2024
Permission Dialogs This CL adds histogram and user action UMA metrics for supervised users using the Extension Install and Parent Permission Dialogs to install extensions. There are also histograms for tracking how much time the user spends on these two dialogs. (cherry picked from commit 0f677aa) [email protected],[email protected],[email protected] Bug: 1022620 Change-Id: I122ac4b3dcbe330fa691f420eecd46db1678e2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181226 Reviewed-by: Scott Violet <[email protected]> Reviewed-by: Devlin <[email protected]> Reviewed-by: Brian White <[email protected]> Commit-Queue: Toby Huang <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#769054} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208594 Reviewed-by: Toby Huang <[email protected]> Cr-Commit-Position: refs/branch-heads/4147@{chromium#80} Cr-Branched-From: 1630782-refs/heads/master@{#768962}
aarongable
pushed a commit
that referenced
this pull request
Apr 18, 2024
…egistering. Since the current entry pointer doesn't exist after the side panel is closed and it is deregistered, make sure this clean up is done earlier. This cl also adds a regression test for this case. (cherry picked from commit 3b1cc2b) Bug: 335166794 Change-Id: I42a635d4613bb2840477353a0b09a916d8844e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457552 Commit-Queue: Caroline Rising <[email protected]> Reviewed-by: David Pennington <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1288303} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5462866 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Caroline Rising <[email protected]> Cr-Commit-Position: refs/branch-heads/6422@{#80} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 16, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6478-1715816004-8d8e9f10d5344881775543f33745ddf8ced6c1b0-4333b0e8738367ef4bbadd8abd4939b9e87de838.profdata to chrome-win64-6478-1715835313-1cb384f117d6f12e5645a9c1d81bee951ad27daa-77027b312eb8d6fec2d7694166296d9cd6359076.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m126.try:win64-chrome Tbr: [email protected] Change-Id: Id2a7a4856984d0cea7159472d157a057ed0b1497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5543156 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6478@{#80} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Jun 14, 2024
…27.0.6533.0-r1 to 127-6440.0-1716810247-benchmark-127.0.6533.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I36620284a5d03bef2a6491d3d2d91c9ac721a49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5629188 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6533@{#80} Cr-Branched-From: 7e0b87e-refs/heads/main@{#1313161}
aarongable
pushed a commit
that referenced
this pull request
Jul 26, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6613-1721886210-c7d13d3c2f5a506e00a30851f4f9bc4f89cf7157-3031aee4544d4045ce94dc6cc785817d0497da09.profdata to chrome-mac-arm-6613-1721892270-16d8fe1e1c3c50ff47901bedc1b6f47b76a74b4b-92f5a83d461e6adfd722b495e4fffd81f5a2c606.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Ie0beefad9152d837a144af55faad8cf862302094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5741553 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6613@{#80} Cr-Branched-From: 03c1799-refs/heads/main@{#1331488}
aarongable
pushed a commit
that referenced
this pull request
Aug 21, 2024
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-6668-1724263181-d74b1075fe78c96ad795169559e43566adb630be-a88e1737073576fa24569f771467c31089d02c5e.profdata to chrome-mac-arm-6668-1724263181-e8a60cda28db1447d4e422ed6975a473c6189f67-a88e1737073576fa24569f771467c31089d02c5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: Idcf9e349020f77e766344033ed4a1921902d31c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804753 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6668@{#80} Cr-Branched-From: 05bc664-refs/heads/main@{#1343869}
aarongable
pushed a commit
that referenced
this pull request
Sep 18, 2024
We expect that there will be very few cases where a client is eligible for the dialog but for which the choice is not required. So we flip the triggering logic to show the dialog if eligible, as a better way to manage the delay until we get a response from the service that will confirm that blocking is required. That delay is limited to a max duration specified via the "dialog_timeout_millis" Finch feature param. Note: depends on the internal https://crrev.com/i/7688982 (cherry picked from commit dabf53d) Fixed: b:365926620 Fixed: 367915819 Change-Id: I0b069c47995ba721cee98327b7c7315e05edcf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5857956 Code-Coverage: [email protected] <[email protected]> Commit-Queue: Nicolas Dossou-Gbété <[email protected]> Reviewed-by: Boris Sazonov <[email protected]> Mega-CQ: Nicolas Dossou-Gbété <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1356399} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872912 Cr-Commit-Position: refs/branch-heads/6723@{#80} Cr-Branched-From: 985f296-refs/heads/main@{#1356013}
aarongable
pushed a commit
that referenced
this pull request
Sep 19, 2024
Roll src/v8 in M126 from 177e00f4a544 to 65b1674f9556 Commits rolled: https://chromium.googlesource.com/v8/v8.git/+log/177e00f4a544..65b1674f9556 Generated by: http://go/bbid/8740422253996572753 (cherry picked from commit 60f1b17) Change-Id: Ia58801c03d9ce15634b007974e81540b4cf59932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5763276 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/6478@{#1898} Cr-Original-Branched-From: e6143ac-refs/heads/main@{#1300313} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5867626 Auto-Submit: Kyle Williams <[email protected]> Reviewed-by: Niko Tsirakis <[email protected]> Commit-Queue: Kyle Williams <[email protected]> Cr-Commit-Position: refs/branch-heads/6478_182@{#80} Cr-Branched-From: 5b5d829-refs/branch-heads/6478@{#1776} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
aarongable
pushed a commit
that referenced
this pull request
Oct 17, 2024
This will make it easier for testers (and users) to test and/or figure out if this is causing issues. (cherry picked from commit 91b508e) Bug: 373673969 Change-Id: If3715f344357402a7bce9cbf3ff63d6ab8406f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5932401 Commit-Queue: Marijn Kruisselbrink <[email protected]> Auto-Submit: Marijn Kruisselbrink <[email protected]> Reviewed-by: Daniel Murphy <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1369059} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5938609 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/6778@{#80} Cr-Branched-From: b21671c-refs/heads/main@{#1368529}
aarongable
pushed a commit
that referenced
this pull request
Nov 15, 2024
Roll Chrome Android ARM64 PGO profile from chrome-android64-6834-1731539854-e013a9786b75810ea645e3158b8c9f9c544c16ce-932dc90d4fab592a4ad6c19923ab408e36335bd3.profdata to chrome-android64-6834-1731546012-61bc775ad8ee3041b35503f80df6a07aa593ce0c-90815c82fe9273e5606ee2915fe8babf4168f17e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I67d6ad843b52ade418d0283c2cd8459af271746e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6021953 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6834@{#80} Cr-Branched-From: 47a3549-refs/heads/main@{#1381561}
aarongable
pushed a commit
that referenced
this pull request
Jan 12, 2025
…133.0.6876.0-r1 to 133-6918.0-1736133807-benchmark-133.0.6943.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I3b30a4d9487f3728d68e309bca481a06acbca8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6170152 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6943@{#80} Cr-Branched-From: 72dd0b3-refs/heads/main@{#1402768}
aarongable
pushed a commit
that referenced
this pull request
Feb 7, 2025
Roll Chrome Android ARM64 PGO profile from chrome-android64-6998-1738798392-d9013566a4389388222117aae3d897e60e7eb5ea-f21a0a50593616a2ce047b857378dc7028fe178a.profdata to chrome-android64-6998-1738799425-1be7389567a9944154cfc14be51299de8285af5a-5cbf3966ba6e31c8ecf438142b7f6bb468c415a3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: If842e2d9a27f1240c67c7216934023d3b124827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6238109 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/6998@{#80} Cr-Branched-From: de9c6fa-refs/heads/main@{#1415337}
aarongable
pushed a commit
that referenced
this pull request
Mar 7, 2025
Roll Chrome Mac PGO profile from chrome-mac-7049-1741196460-b7a1fc72fba39eeab9de1a9281df18b33c99188a-c2e215e78fbb85801686899316bedcc00175624b.profdata to chrome-mac-7049-1741218663-1678beb890af7531cc414300cf06d797fff6bd40-b1342f749f9f80bad67d0a7d9ecdfb26c73d30d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m135.try:mac-chrome Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I11edb552f951ad4a224984227fb6c37f22c56744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332213 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7049@{#80} Cr-Branched-From: 2dab784-refs/heads/main@{#1427262}
aarongable
pushed a commit
that referenced
this pull request
Apr 3, 2025
Roll Chrome Win32 PGO profile from chrome-win32-7103-1743592705-106f34d4c6a84158d08e8075fdfca60a6d13aa06-575c4c2b7d0ca676e8d036eef965dbd315449327.profdata to chrome-win32-7103-1743615748-1c7061a696fc5ddad2b49d6f5b83176da08edcb1-c6f2aef20b5079e15a49364febe368c6607edec6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m136.try:win-chrome Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: Ieaed89830d360b7639c795de974ce357c5016d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427569 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7103@{#80} Cr-Branched-From: e09430c-refs/heads/main@{#1440670}
aarongable
pushed a commit
that referenced
this pull request
May 2, 2025
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-7151-1746057520-ac2388e7ad53a39a26c8122652ab8517bb7538d4-ca9c44f8927d89a331c1cc9f9d5db645827cf4b4.profdata to chrome-mac-arm-7151-1746063216-8931c1a4dcbe1b9ee0a962c55cb01cc8762ba3f4-a7c34dda3d3934833d8de78bf023351a09b33e26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I021c53feda0bbfa48a3acfb9a18a79d669e2f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6504278 Bot-Commit: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7151@{#80} Cr-Branched-From: 8e0d32e-refs/heads/main@{#1453031}
aarongable
pushed a commit
that referenced
this pull request
May 29, 2025
Original change's description: > Add Android WebView testing config for TimedHTMLParserBudget > > Bug: 40279826 > Change-Id: I947a5010f7a2bbc4b48b31af56c20b859c09ba49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6590772 > Commit-Queue: Minoru Chikamune <[email protected]> > Reviewed-by: Yoshisato Yanagisawa <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1466233} Bug: 420836181,40279826 Change-Id: I947a5010f7a2bbc4b48b31af56c20b859c09ba49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6596921 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7204@{#80} Cr-Branched-From: d5de512-refs/heads/main@{#1465706}
aarongable
pushed a commit
that referenced
this pull request
Jun 26, 2025
Roll Chrome Mac PGO profile from chrome-mac-7258-1750850725-98493b0f817d1dcfbbc081cc7d894894bb8d3000-4f77a88d488249174d7d05a32b1db46b25cf293a.profdata to chrome-mac-7258-1750873809-1b43358584b9fe824fb3a8682ac4b7ec5c769a59-0d0b78cbc3d531149dc2adf26ea86f2c4abff34f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m139.try:mac-chrome Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I28468541f88a6edda10a62509f4bc42c5c0412be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6675465 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7258@{#80} Cr-Branched-From: f600d06-refs/heads/main@{#1477651}
aarongable
pushed a commit
that referenced
this pull request
Jul 21, 2025
https://chromium.googlesource.com/external/github.com/WebKit/JetStream.git/+log/c1851d95afb8..8c28a5fbd897 2025-07-21 [email protected] Fix typo in headers fetch request (#80) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/jetstream-main-chromium Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: [email protected],[email protected] Change-Id: I838f17fa7b8ce6050ced1b6120708fb2261f2e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6773335 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#1489392}
aarongable
pushed a commit
that referenced
this pull request
Aug 6, 2025
This CL makes the title text on the entry point screen and the import screen the same size - they used to be different since one of them is a subclass of PromoStyleViewController and the other the ConfirmationAlertViewController. Also, one of them has a different detent, so the method provided by promo_style/utils.h cannot be readily used. Added new helper method. (cherry picked from commit 0bd16e2) Fixed: 436569855 Bug: 420703283 Change-Id: I7d775d2720f2c8e32d6b4bfddcc8d1aecb8c5a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818898 Commit-Queue: Alexis Hétu <[email protected]> Commit-Queue: Ginny Huang <[email protected]> Reviewed-by: Alexis Hétu <[email protected]> Auto-Submit: Ginny Huang <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1496521} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6825421 Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7339@{#80} Cr-Branched-From: 27be8b7-refs/heads/main@{#1496484}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Aug 28, 2025
Tabs are briefly resized to their ideal size when torn out of a window during a drag, then updated to the size and position they had before the drag for better visuals. The group visuals were getting updated based on the ideal bounds (which are never painted and therefore are not visible) but not the drag-appropriate bounds, resulting in strange group highlights and underlines. This causes the tab visuals to be updated after the appropriate dragging bounds are set on the tabs and tab group header. (cherry picked from commit 0438e23) Bug: 1099047 Change-Id: I918d34efc47c6ec40e8558c0de5f8cbae2ad8a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268389 Auto-Submit: Dana Fried <[email protected]> Commit-Queue: Charlene Yan <[email protected]> Reviewed-by: Charlene Yan <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#782840} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278302 Cr-Commit-Position: refs/branch-heads/4183@{chromium#80} Cr-Branched-From: 740e9e8-refs/heads/master@{#782793}
aarongable
pushed a commit
that referenced
this pull request
Sep 4, 2025
Roll Chrome Android ARM64 PGO profile from chrome-android64-7390-1756918005-06fe8152f76b71d0f9f6201ce0cb50a7a3d95d0a-dc11ad35eb1c80941e5389bca57591f8240f4fd2.profdata to chrome-android64-7390-1756924208-72219af0f204feb4b94536ee4338fa2698914dc7-ee894a7a4d1141360a33622008e2409e63aa5d60.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I3df4faa8ddf8688d11698ecf71fc7c9c2deab0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6913629 Bot-Commit: Chrome Release Autoroll <[email protected]> Commit-Queue: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7390@{#80} Cr-Branched-From: d481efc-refs/heads/main@{#1509326}
aarongable
pushed a commit
that referenced
this pull request
Oct 2, 2025
…igation Original change's description: > Enable carrying sticky-activation state across same-origin navigation > > Intent to Ship: > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68b0b943.050a0220.270bc4.0090.GAE%40google.com > > Spec PR (already secured another browser's approval): > whatwg/html#11454 > > Fixed: 433729626 > Change-Id: Ib475166aeec709837c9d67f6936f51abdc38c6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6961179 > Commit-Queue: Vladimir Levin <[email protected]> > Auto-Submit: Mustaq Ahmed <[email protected]> > Reviewed-by: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1523044} (cherry picked from commit 96f69eb) Bug: 448428855,433729626 Change-Id: Ib475166aeec709837c9d67f6936f51abdc38c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004556 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Mustaq Ahmed <[email protected]> Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/7444@{#80} Cr-Branched-From: 29907d3-refs/heads/main@{#1522585}
aarongable
pushed a commit
that referenced
this pull request
Oct 30, 2025
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-7499-1761767193-51f550b4695a154af3bb935a4fcc470c219cfaae-e680d922d8de8b2501dcf000cfae16eb8633b431.profdata to chrome-mac-arm-7499-1761773460-2b2480a3479993a56bc85331376f17698f47131b-d2c1c125e472b41141d56b98eecd0cf5a252b6c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium-beta Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: I00e19d7872f24c09005773162546269c5b517252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7098781 Commit-Queue: chromium-autoroll <[email protected]> Bot-Commit: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7499@{#80} Cr-Branched-From: b304398-refs/heads/main@{#1536371}
aarongable
pushed a commit
that referenced
this pull request
Dec 4, 2025
…bqd0... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/orderfile-webview-arm-chromium-beta Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Merge-Approval-Bypass: Chrome autoroller Change-Id: Ie519208b5a0672676f3103359c302bba54de46d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224313 Commit-Queue: Chrome Release Autoroll <[email protected]> Bot-Commit: Chrome Release Autoroll <[email protected]> Cr-Commit-Position: refs/branch-heads/7559@{#80} Cr-Branched-From: 223dfba-refs/heads/main@{#1552494}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added me as a new Author. I have set up chromium using depot-tools and started fixing bugs.