Migrate to 2018 edition #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
BTW, how about migrating to 2018 edition? |
Contributor
|
I'm okay with migrating to edition 2018. But rustfmt.... Here is my comment on previous PR doing this: #9 (comment). I also prefer max_width=80 it's more comfortable side-by-side editing and also for reviewing diffs on github. |
Signed-off-by: koushiro <[email protected]>
Signed-off-by: koushiro <[email protected]>
Contributor
Author
|
@tailhook PTAL again :) |
tailhook
reviewed
Jan 17, 2020
Contributor
tailhook
left a comment
tailhook
left a comment
There was a problem hiding this comment.
Looks good, except few tiny things.
Signed-off-by: koushiro <[email protected]>
Contributor
|
Looks nice. Thank you! |
Contributor
|
By the way, env_logger which depends on this, has MSRV 1.31. Is there anything that requires 1.32? |
Contributor
|
Hm, it seems |
Contributor
Author
|
At first, I just raised MSRV to 1.32 in order to use rand 0.7 in the test. Now it seems that we must add |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.