Skip to content

Conversation

@xoac
Copy link
Contributor

@xoac xoac commented Oct 29, 2019

apply rustfmt on this lib
sync doc in src/lib.rs with information in README.md

@tailhook
Copy link
Contributor

I'm okay with doc update. But any specific reason why you have applied rustfmt? Most (if not all) things aren't improvements here, some are harmful. To name a few:

  1. Bytes in declaration of buf (date.rs:32) are aligned to have newlines at separators T and .
  2. Loop comment in date.rs:278 became in the wrong place
  3. I like the contrast between an = assignment and configuration="parameters" (spaces around equals sign).

I understand rustfmt is a useful tradeoff for projects with high contribution traffic where it's easier to settle on rustfmt than to teach everyone good style. But this crate is prettly low-maintenance. And there is no need for such extra changes.

@xoac
Copy link
Contributor Author

xoac commented Oct 29, 2019

I used rustfmt because it's done im my IDE on save. So no general purpose.

I think I can come back to master, Add skip attributes and then do rustfmt and update doc.

or just update doc. whatever you prefer

@tailhook
Copy link
Contributor

tailhook commented Nov 1, 2019

Thanks, I prefer just updating docs.

@xoac xoac reopened this Nov 4, 2019
@xoac xoac changed the title rustfmt + Update doc Update doc Nov 6, 2019
@xoac
Copy link
Contributor Author

xoac commented Nov 6, 2019

Done

@tailhook tailhook merged commit 82f148d into chronotope:master Nov 6, 2019
@tailhook
Copy link
Contributor

tailhook commented Nov 6, 2019

Merged. Thanks!

@tailhook tailhook mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants