Skip to content

Modified Product model according to v19 API #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 19, 2020
Merged

Modified Product model according to v19 API #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
931f2b9
Modified Product model according to v19 API
marcserrat Feb 19, 2020
9f25a30
Modified Product Mock
marcserrat Feb 19, 2020
3cbb8c7
Fixed name of mock
marcserrat Feb 19, 2020
521a939
Fixed 2 code smells due unusage of constant, reformated files accordi…
marcserrat Feb 19, 2020
a7c4e40
Added test to ensure 100% coverage on Products
marcserrat Feb 19, 2020
cbbf909
Fixed phpDoc return string
marcserrat Feb 19, 2020
7c9b05c
Added functionality to list tierAccounts
marcserrat Mar 2, 2020
f2c8e01
Added TARs, automation to handle them
marcserrat Mar 3, 2020
2a85d89
Added to SDK support to operate with new Subscriptions Module
marcserrat Mar 3, 2020
e585b61
Fixed codeSmell
marcserrat Mar 3, 2020
665234c
Added modifications for new Usage schemas, modified other classes acc…
marcserrat Mar 4, 2020
7d1f011
Added support for usage file categories
marcserrat Mar 4, 2020
2eeca15
Added support for from/to on usage file creation
marcserrat Mar 5, 2020
dee6d40
Removed unneeded line to remove code smell
marcserrat Mar 5, 2020
922fb9d
Changed Copyright year
marcserrat Mar 5, 2020
1fb0b52
updated README
marcserrat Mar 6, 2020
af1dfa6
Correction of a typo on Readme file
marcserrat Mar 6, 2020
cf13980
Changed exception to capture full API output
Mar 14, 2020
376a2f0
Fixed issue that item_unit was not present in upload file, removed de…
Mar 14, 2020
6ae2db2
Small changes relative to PR
Mar 17, 2020
c6aa4b6
Changed copyright to include date range
Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small changes relative to PR
  • Loading branch information
Marc Serrat authored and Marc Serrat committed Mar 17, 2020
commit 6ae2db25b6246e7200a4ed43940614ef31a57ebd
1 change: 1 addition & 0 deletions src/Constants.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ class Constants
const GENERIC_CONVERSATION_ERROR_MESSAGE = 'Error while saving result on conversation for request ';
const SUBSCRIPTIONS_ASSETS_PATH = '/subscriptions/assets/';
const SUBSCRIPTIONS_REQUESTS_PATH = '/subscriptions/requests/';
const ASSETS_PATH = '/assets/';
}
2 changes: 1 addition & 1 deletion src/FulfillmentAutomation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ protected function dispatchTierConfig($tierConfigRequest)
if ($this->config->products && !in_array(
$tierConfigRequest->configuration->product->id,
$this->config->products
)) {
)) {
return 'Invalid product';
}

Expand Down
7 changes: 6 additions & 1 deletion src/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,12 @@ public static function modelize($key, $value)
switch (gettype($value)) {
case 'object':

$namespaces = ['\Connect\\', '\Connect\Usage\\', '\Connect\Product\Capabilities\\', 'Connect\Product\Actions\\', 'Connect\Subscription\\'];
$namespaces = ['\Connect\\',
'\Connect\Usage\\',
'\Connect\Product\Capabilities\\',
'Connect\Product\Actions\\',
'Connect\Subscription\\'
];

/**
* if the item is an object search if there are any model that match with it:
Expand Down
10 changes: 5 additions & 5 deletions src/Modules/Directory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function listAssets($filters = null)
: explode(',', $this->config->products));
}

$body = $this->sendRequest('GET', '/assets' . $query->compile());
$body = $this->sendRequest('GET', \Connect\Constants::ASSETS_PATH . $query->compile());

/** @var Asset[] $models */
return Model::modelize('assets', json_decode($body));
Expand All @@ -72,7 +72,7 @@ public function listAssets($filters = null)
*/
public function getAssetById($assetID)
{
$body = $this->sendRequest('GET', '/assets/' . $assetID);
$body = $this->sendRequest('GET', \Connect\Constants::ASSETS_PATH . $assetID);
/** @var Asset $model */
return Model::modelize('asset', json_decode($body));
}
Expand All @@ -91,7 +91,7 @@ public function listProducts($filters = null)
$query = new \Connect\RQL\Query();
}

$body = $this->sendRequest('GET', '/products' . $query->compile());
$body = $this->sendRequest('GET', \Connect\Constants::PRODUCTS_PATH . $query->compile());

/** @var \Connect\Product[] $models */
return Model::modelize('products', json_decode($body));
Expand All @@ -105,7 +105,7 @@ public function listProducts($filters = null)

public function getProduct($productID)
{
$body = $this->sendRequest('GET', '/products/' . $productID);
$body = $this->sendRequest('GET', \Connect\Constants::PRODUCTS_PATH . $productID);
/** @var Product $model */
return Model::modelize('product', json_decode($body));
}
Expand All @@ -131,7 +131,7 @@ public function listTierConfigs($filters = null)
: explode(',', $this->config->products));
}

$body = $this->sendRequest('GET', '/tier/configs' . $query->compile());
$body = $this->sendRequest('GET', \Connect\Constants::TIER_CONFIG_PATH . $query->compile());

/** @var \Connect\TierConfig[] $models */
return Model::modelize('tierConfig', json_decode($body));
Expand Down