Skip to content

Modified Product model according to v19 API #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 19, 2020
Merged

Modified Product model according to v19 API #54

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
931f2b9
Modified Product model according to v19 API
marcserrat Feb 19, 2020
9f25a30
Modified Product Mock
marcserrat Feb 19, 2020
3cbb8c7
Fixed name of mock
marcserrat Feb 19, 2020
521a939
Fixed 2 code smells due unusage of constant, reformated files accordi…
marcserrat Feb 19, 2020
a7c4e40
Added test to ensure 100% coverage on Products
marcserrat Feb 19, 2020
cbbf909
Fixed phpDoc return string
marcserrat Feb 19, 2020
7c9b05c
Added functionality to list tierAccounts
marcserrat Mar 2, 2020
f2c8e01
Added TARs, automation to handle them
marcserrat Mar 3, 2020
2a85d89
Added to SDK support to operate with new Subscriptions Module
marcserrat Mar 3, 2020
e585b61
Fixed codeSmell
marcserrat Mar 3, 2020
665234c
Added modifications for new Usage schemas, modified other classes acc…
marcserrat Mar 4, 2020
7d1f011
Added support for usage file categories
marcserrat Mar 4, 2020
2eeca15
Added support for from/to on usage file creation
marcserrat Mar 5, 2020
dee6d40
Removed unneeded line to remove code smell
marcserrat Mar 5, 2020
922fb9d
Changed Copyright year
marcserrat Mar 5, 2020
1fb0b52
updated README
marcserrat Mar 6, 2020
af1dfa6
Correction of a typo on Readme file
marcserrat Mar 6, 2020
cf13980
Changed exception to capture full API output
Mar 14, 2020
376a2f0
Fixed issue that item_unit was not present in upload file, removed de…
Mar 14, 2020
6ae2db2
Small changes relative to PR
Mar 17, 2020
c6aa4b6
Changed copyright to include date range
Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed codeSmell
  • Loading branch information
@marcserrat
marcserrat committed Mar 3, 2020
commit e585b614a7e81a45a8c3f8eec2dacc4a5e265032
12 changes: 0 additions & 12 deletions src/Subscription/SubscriptionItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,6 @@ class SubscriptionItem extends Model
* @param string $id
* @return Param
*/
/*
* Not Implemented in scope of v19
public function getParameterByID($id)
{
$param = current(array_filter($this->params, function (Param $param) use ($id) {
return ($param->id === $id);
}));

return ($param) ? $param : null;
}
*/

public function setBilling($billing)
{
$this->billing = Model::modelize('Billing', $billing);
Expand Down