Fix bug with dns zone #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
approved these changes
Oct 10, 2018
aknysh
reviewed
Oct 10, 2018
| module "dns" { | ||
| source = "git::https://github.com/cloudposse/terraform-aws-route53-cluster-hostname.git?ref=tags/0.2.1" | ||
| enabled = "${var.enabled}" | ||
| enabled = "${var.enabled == "true" && var.zone_id != "false"}" |
There was a problem hiding this comment.
we usually use this pattern
https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/main.tf#L124
but the one from @MoonMoon1919 is ok as well
There was a problem hiding this comment.
I think he did this because zone_id was previously set to false in a different PR.
Agree we should change this to our normal pattern.
There was a problem hiding this comment.
Yeah, that's why I used this approach. Tonight I can remove the default value and submit a PR to address this. #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it is
Why
If you don't require a DNS record to be created the previous default for the
zone_idvariable would still trigger a resource to be created, then cause the run to fail because the "false" zone_id doesn't exist.