Skip to content

Fix bug with dns zone #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Fix bug with dns zone #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ resource "aws_cloudwatch_metric_alarm" "cache_memory" {

module "dns" {
source = "git::https://github.com/cloudposse/terraform-aws-route53-cluster-hostname.git?ref=tags/0.2.1"
enabled = "${var.enabled}"
enabled = "${var.enabled == "true" && var.zone_id != "false"}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually use this pattern
https://github.com/cloudposse/terraform-aws-rds-cluster/blob/master/main.tf#L124

but the one from @MoonMoon1919 is ok as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he did this because zone_id was previously set to false in a different PR.

https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/13/files#diff-c9ac8098c5ea9d3e6a9a596ff0c512a4R107

Agree we should change this to our normal pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I used this approach. Tonight I can remove the default value and submit a PR to address this. #26

namespace = "${var.namespace}"
name = "${var.name}"
stage = "${var.stage}"
Expand Down