Fixing ReadMe Issues #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
nimakaviani
requested changes
Apr 11, 2024
README.md
Outdated
| aws route53 list-hosted-zones-by-name --dns-name <YOUR_DOMAIN_NAME> --query 'HostedZones[0].Id' --output text | cut -d'/' -f3 | ||
| # in the setups/config file, update the zone id. | ||
| HOSTEDZONE_ID=ZO020111111 | ||
| HOSTEDZONE_ID: ZO020111111 |
There was a problem hiding this comment.
this should actually be hosted_zone_id: if we want to get this right. can you update the PR plz?
There was a problem hiding this comment.
@nimakaviani Yes my bad, fixed it, Please merge this. Thanks!
Signed-off-by: Elamaran Shanmugam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing ReadMe Issues