Skip to content

Fixing ReadMe Issues #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Fixing ReadMe Issues #36

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ac2305
Updating and Fixing EKS Cluster Config
elamaran11 Apr 10, 2024
1096c76
DCO
elamaran11 Apr 10, 2024
9b0976b
DCO
elamaran11 Apr 10, 2024
a145434
Readme errors
elamaran11 Apr 10, 2024
e51ec4c
Merge branch 'cnoe-io:main' into main
elamaran11 Apr 10, 2024
9dd19df
Readme errors
elamaran11 Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Readme errors 
Signed-off-by: Elamaran Shanmugam <[email protected]>
  • Loading branch information
@elamaran11
elamaran11 committed Apr 10, 2024
commit a1454342b6f950ccd68f43993ce2b4b482227ba4
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Follow the following steps to get started.
```bash
aws route53 list-hosted-zones-by-name --dns-name <YOUR_DOMAIN_NAME> --query 'HostedZones[0].Id' --output text | cut -d'/' -f3
# in the setups/config file, update the zone id.
HOSTEDZONE_ID=ZO020111111
HOSTEDZONE_ID: ZO020111111
Copy link
Contributor

@nimakaviani nimakaviani Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually be hosted_zone_id: if we want to get this right. can you update the PR plz?

Copy link
Contributor Author

@elamaran11 elamaran11 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimakaviani Yes my bad, fixed it, Please merge this. Thanks!

```
5. Update the [`setups/config`](setups/config.yaml) file with your own values.
6. Run `setups/install.sh` and follow the prompts. See the section below about monitoring installation progress.
Expand All @@ -145,7 +145,7 @@ Go to [`http://localhost:8081`](http://localhost:8081) and login with the userna

### If you installed it without automatic DNS configuration.

If you set `MANAGED_DNS=false`, you are responsible for updating DNS records, thus external-dns is not installed. You have to set the following DNS records:
If you set `enable_dns_management: false`, you are responsible for updating DNS records, thus external-dns is not installed. You have to set the following DNS records:
- `backstage.<DOMAIN_NAME>`
- `keycloak.<DOMAIN_NAME>`
- `argo.<DOMAIN_NAME>`
Expand Down