Skip to content

Conversation

@hazzik
Copy link

@hazzik hazzik commented Apr 1, 2025

Updated update github.com/prometheus/client_golang to v1.15.0 to minimal version that does not have a myriads of unnecessary dependencies.

This commit is just a result of:

go get github.com/prometheus/[email protected]
go mod tidy

@hazzik hazzik requested a review from a team as a code owner April 1, 2025 10:21
@hazzik hazzik requested a review from jbowens April 1, 2025 10:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@hazzik hazzik changed the title go.mod: update github.com/prometheus/client_golang go.mod: update github.com/prometheus/common to 0.38.0 Apr 1, 2025
@RaduBerinde
Copy link
Member

This is an indirect dependency and I'm hesitant to downgrade it. Also, what Pebble version do you use? You'd need this on a pebble-release- branch.

@hazzik
Copy link
Author

hazzik commented Apr 1, 2025

Thanks for feedback.

This is an indirect dependency

It is pretty much direct, updating github.com/prometheus/client_golang to 0.15.0 would produce almost the same diff, because prometheus/client_golang and prometheus/common have circular dependency on each other.

I could redo with the upgrade of client_golang to 0.15.0 as I did initially, that would be a direct dependency upgrade. Would it be acceptable?

Also, what Pebble version do you use?

v1.1.2 -- the version used by go-ethereum. We have dependency on it, and I'm trying to cleanup things from bottom up.

You'd need this on a pebble-release- branch.

Thanks for suggestion, I'll re-target to that branch.

@hazzik hazzik changed the base branch from master to pebble-release-1.1 April 1, 2025 14:54
@RaduBerinde
Copy link
Member

I could redo with the upgrade of client_golang to 0.15.0 as I did initially, that would be a direct dependency upgrade. Would it be acceptable?

Oh, I see. Yes, updating that is good. I can do that on the other branches separately, you'll care about the pebble-release-1.1 branch.

@hazzik hazzik changed the title go.mod: update github.com/prometheus/common to 0.38.0 go.mod: github.com/prometheus/client_golang to v1.15.0 Apr 1, 2025
@hazzik hazzik changed the title go.mod: github.com/prometheus/client_golang to v1.15.0 go.mod: update github.com/prometheus/client_golang to v1.15.0 Apr 1, 2025
@hazzik

This comment was marked as outdated.

@RaduBerinde
Copy link
Member

Looks like CI isn't set up properly on this branch. I pushed a commit that should fix it, could you rebase? Thanks!

@hazzik
Copy link
Author

hazzik commented Apr 1, 2025

Done

@RaduBerinde
Copy link
Member

I verified that the diff is exactly what I get when I do go get github.com/prometheus/[email protected]; go mod tidy.

@RaduBerinde RaduBerinde merged commit c8e13d9 into cockroachdb:pebble-release-1.1 Apr 1, 2025
9 of 10 checks passed
@RaduBerinde
Copy link
Member

I tagged a v1.1.5 you can upgrade to. https://github.com/cockroachdb/pebble/releases/tag/v1.1.5

@hazzik hazzik deleted the deps/prometheus_client branch April 6, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants