-
Notifications
You must be signed in to change notification settings - Fork 519
go.mod: update github.com/prometheus/client_golang to v1.15.0 #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: update github.com/prometheus/client_golang to v1.15.0 #4462
Conversation
|
This is an indirect dependency and I'm hesitant to downgrade it. Also, what Pebble version do you use? You'd need this on a |
|
Thanks for feedback.
It is pretty much direct, updating I could redo with the upgrade of client_golang to 0.15.0 as I did initially, that would be a direct dependency upgrade. Would it be acceptable?
v1.1.2 -- the version used by go-ethereum. We have dependency on it, and I'm trying to cleanup things from bottom up.
Thanks for suggestion, I'll re-target to that branch. |
Oh, I see. Yes, updating that is good. I can do that on the other branches separately, you'll care about the |
This comment was marked as outdated.
This comment was marked as outdated.
|
Looks like CI isn't set up properly on this branch. I pushed a commit that should fix it, could you rebase? Thanks! |
|
Done |
|
I verified that the diff is exactly what I get when I do |
c8e13d9
into
cockroachdb:pebble-release-1.1
|
I tagged a v1.1.5 you can upgrade to. https://github.com/cockroachdb/pebble/releases/tag/v1.1.5 |
Updated update
github.com/prometheus/client_golangto v1.15.0 to minimal version that does not have a myriads of unnecessary dependencies.This commit is just a result of: