Skip to content

Conversation

@hazzik
Copy link
Contributor

@hazzik hazzik commented Apr 1, 2025

Update github.com/prometheus/common to 0.38.0 to reduce clutter in go.sum

@hazzik hazzik force-pushed the deps/prometheus_common branch from b9b229f to f4e0545 Compare April 1, 2025 12:48
@hazzik hazzik changed the title go.mod: update github.com/prometheus/common to 0.42.0 go.mod: update github.com/prometheus/common to 0.38.0 Apr 1, 2025
@MariusVanDerWijden
Copy link
Member

A nice diff, but its an indirect dependency pulled in by pebble. We should not update indirect dependencies directly imo

@MariusVanDerWijden
Copy link
Member

We can consider upgrading pebble once they cut a release with your PR over there merged: cockroachdb/pebble#4462

@hazzik
Copy link
Contributor Author

hazzik commented Apr 1, 2025

Created pr with pebble update: #31541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants