Use qualified std::isnan. #234
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a recently updated arch system, the
kinect2_viewerfails to compile becauseisnanis not defined in global scope. The header<cmath>defines it in thestdnamespace [1].std::isnanis only available since C++11, but if I'm not mistaken the project already requires C++11 so that should not be a problem.This PR uses the fully qualified name
std::isnanto fix the compilation issue.[1] http://en.cppreference.com/w/cpp/numeric/math/isnan