Skip to content

Conversation

@de-vri-es
Copy link
Contributor

On a recently updated arch system, the kinect2_viewer fails to compile because isnan is not defined in global scope. The header <cmath> defines it in the std namespace [1].

std::isnan is only available since C++11, but if I'm not mistaken the project already requires C++11 so that should not be a problem.

This PR uses the fully qualified name std::isnan to fix the compilation issue.

[1] http://en.cppreference.com/w/cpp/numeric/math/isnan

@kohrt
Copy link

kohrt commented Feb 26, 2016

Thanks for this PR. That's right, the project needs C++11. But I looked at the code and the isnan is not really needed anyway, because the uint16_t depth value is always a valid number, therefore the float value will never be NAN. I will just remove it from the code.

@de-vri-es
Copy link
Contributor Author

Ah even better. This can be closed than :)

@de-vri-es de-vri-es closed this Feb 26, 2016
@kohrt
Copy link

kohrt commented Feb 29, 2016

fixed with 1a5703b

@de-vri-es
Copy link
Contributor Author

Awesome, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants