Remote development environments changes #5359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit a839611 is at https://pr5359.build.csb.dev/s/new. |
SaraVieira
reviewed
Jan 13, 2021
| .concat(...stats.compilation.children.map(child => child.warnings)) | ||
| .filter(warning => warning.error.name !== 'CriticalDependencyWarning'); | ||
| .filter(warning => warning.error.name !== 'CriticalDependencyWarning') | ||
| // ignore "Error: Can't resolve 'sugarss' in '/client/node_modules/postcss-import/lib'" warning |
|
It looks good! Did you test running it in the docker container to make sure it still works local? Also maybe a good idea to revert the yarn.lock |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a839611:
|
CompuIves
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.